generated from metaplex-foundation/solana-project-template
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third party plugins staging to main #107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add structs and ixs for third party plugins * lifecyle_checks into a HashMap and add check_external_registry * Use Vec for third party lifecycle checks * Combine lifecycle hooks and allow custom seeds * Regenerate IDL and clients * Rename external plugin header to external plugin * Also move external plugin data offset inside of external plugin. * Regenerate IDL and clients * Add create_v2 and create_colleciton_v2 basic structure * Regenerate IDL and clients * Add external plugin init info container * Regenerate IDL and clients * Add init and update structs for external plugins * Also limit hookable lifecycle events. * Resolve other PR comments. * Regenerate IDL and clients
* Move key info into external plugin init info * Regenerate clients and IDL
* Do not allow data init on 3P plugins * Also no lifecycle checks for data store. * Regenerate IDL and clients
* change external plugins to external registry * Regenerate IDL and clients * Update custom JS deserializer
Add new data auth and data ixes
Adding WIP for adding external plugins.
* Serde Pubkey DisplayFromStr (#78) * Update kinobi version * Regenerate clients * chore: Release mpl-core version 0.5.0 --------- Co-authored-by: danenbm <[email protected]>
- sdk v1 - retain mostly backwards compatibility some types have changed name: BasePluginAuthority -> PluginAuthority - many generated types have changed from Type -> BaseType - support external plugins
* Regenerate IDL and clients * Add Oracle validation type * Regenerate IDL and clients * Update JS SDK for ValidationResultsOffset * fix minor type issues --------- Co-authored-by: Nhan Phan <[email protected]>
* Run on third-party-plugins-staging for now * Format fix
* bump version v1-alpha * bump version v1-alpha * initial rename * Rename Oracle pda - stacked onto rename external plugin (#121) * Format fix * Rename oracle pda to base_address_config in program * Regenerate IDL and clients * Update oracle SDK functions * Format JS and fix all tests * rename to external plugin adapater * formatting * rename back to external validation result * use internal validationresult type * rename a few more things * minor nits, comments --------- Co-authored-by: Michael Danenberg <[email protected]>
* bump version v1-alpha * remove unused type
…rive bug, better asset vs. collection plugin types (#126)
nhanphan
approved these changes
May 20, 2024
blockiosaurus
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10/10 would review again
nhanphan
added a commit
that referenced
this pull request
May 31, 2024
* main: chore: Release mpl-core version 0.7.0 Process internal and external plugins together in indexable asset (#136) Nhan/revert burn rent (#134) Improve DAS indexing for unknown lifecycle checks (#133) Add external plugins handling to `IndexableAsset` (#128) add lint precommit hook (#127) use solana 1.18 to deploy (#129) Third party plugins staging to main (#107)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these changes have been previously code reviewed. See below.