Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third party plugins staging to main #107

Merged
merged 85 commits into from
May 20, 2024
Merged

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented May 4, 2024

All of these changes have been previously code reviewed. See below.

danenbm and others added 30 commits April 11, 2024 14:03
* Add structs and ixs for third party plugins

* lifecyle_checks into a HashMap and add check_external_registry

* Use Vec for third party lifecycle checks

* Combine lifecycle hooks and allow custom seeds

* Regenerate IDL and clients

* Rename external plugin header to external plugin

* Also move external plugin data offset inside of
external plugin.

* Regenerate IDL and clients

* Add create_v2 and create_colleciton_v2 basic structure

* Regenerate IDL and clients

* Add external plugin init info container

* Regenerate IDL and clients

* Add init and update structs for external plugins

* Also limit hookable lifecycle events.

* Resolve other PR comments.

* Regenerate IDL and clients
* Move key info into external plugin init info

* Regenerate clients and IDL
* Do not allow data init on 3P plugins

* Also no lifecycle checks for data store.

* Regenerate IDL and clients
* change external plugins to external registry

* Regenerate IDL and clients

* Update custom JS deserializer
* Serde Pubkey DisplayFromStr (#78)

* Update kinobi version

* Regenerate clients

* chore: Release mpl-core version 0.5.0

---------

Co-authored-by: danenbm <[email protected]>
- sdk v1
- retain mostly backwards compatibility some types have changed name: BasePluginAuthority -> PluginAuthority
- many generated types have changed from Type -> BaseType
- support external plugins
* Regenerate IDL and clients

* Add Oracle validation type

* Regenerate IDL and clients

* Update JS SDK for ValidationResultsOffset

* fix minor type issues

---------

Co-authored-by: Nhan Phan <[email protected]>
* Run on third-party-plugins-staging for now

* Format fix
* bump version v1-alpha

* bump version v1-alpha

* initial rename

* Rename Oracle pda - stacked onto rename external plugin (#121)

* Format fix

* Rename oracle pda to base_address_config in program

* Regenerate IDL and clients

* Update oracle SDK functions

* Format JS and fix all tests

* rename to external plugin adapater

* formatting

* rename back to external validation result

* use internal validationresult type

* rename a few more things

* minor nits, comments

---------

Co-authored-by: Michael Danenberg <[email protected]>
* bump version v1-alpha

* remove unused type
…rive bug, better asset vs. collection plugin types (#126)
@danenbm danenbm marked this pull request as ready for review May 20, 2024 21:57
Copy link
Contributor

@blockiosaurus blockiosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10 would review again

@danenbm danenbm merged commit 9053d3b into main May 20, 2024
22 checks passed
nhanphan added a commit that referenced this pull request May 31, 2024
* main:
  chore: Release mpl-core version 0.7.0
  Process internal and external plugins together in indexable asset (#136)
  Nhan/revert burn rent (#134)
  Improve DAS indexing for unknown lifecycle checks (#133)
  Add external plugins handling to `IndexableAsset` (#128)
  add lint precommit hook (#127)
  use solana 1.18 to deploy (#129)
  Third party plugins staging to main (#107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants