Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mpl-core crate and indexing for AppData external plugin #202

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Update mpl-core crate and indexing for AppData external plugin #202

merged 7 commits into from
Aug 2, 2024

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Jul 25, 2024 •
edited
Loading

Notes

  • Update mpl-core version to new published beta crate.
  • Transform data_authority and linked_app_data parent key to be consistent with other PluginAuthority values.
  • Add AppData, LinkedAppData, and DataSection integration tests.
  • (Unrelated maintenence) update docker build to use latest Rust version image.

@danenbm danenbm force-pushed the danenbm/mpl-core-app-data branch from 6d05dc4 to bec1ca5 Compare July 26, 2024 05:45
@danenbm danenbm changed the title Update mpl-core crate and indexing for AppData external plugin Update mpl-core crate and indexing for AppData external plugin Jul 26, 2024
@danenbm danenbm mentioned this pull request Jul 26, 2024
Merged
@danenbm danenbm marked this pull request as ready for review July 29, 2024 14:56
@danenbm danenbm requested a review from n00m4d July 29, 2024 15:05
@linear linear bot mentioned this pull request Jul 30, 2024
Merged
pmantica11
pmantica11 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@pmantica11 pmantica11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it's super well tested. So I am approving.

@danenbm danenbm merged commit 6875b16 into main Aug 2, 2024
3 checks passed
@danenbm danenbm deleted the danenbm/mpl-core-app-data branch August 2, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmantica11 pmantica11 pmantica11 approved these changes

@kespinola kespinola kespinola approved these changes

@blockiosaurus blockiosaurus Awaiting requested review from blockiosaurus

@n00m4d n00m4d Awaiting requested review from n00m4d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danenbm @kespinola @pmantica11