sed doesn't like newlines #4847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifieldt
approved these changes
Sep 24, 2024
fifieldt
requested changes
Sep 24, 2024
fifieldt
approved these changes
Sep 24, 2024
panaceya
added a commit
to mesh-mk-ua/meshtastic-firmware
that referenced
this pull request
Sep 25, 2024
* sed doesn't like newlines (meshtastic#4847) * sed doesn't like newlines * fold remove-debug-flags block * PATH is a system env var * Runners don't like rm -f ${workspace path} * chomp trailing newline (meshtastic#4848) * Fix Ublox M10 Setup (meshtastic#4842) There is no EXTINT pin available on the Tdeck, which uses the Ublox M10 GPS. Therefore our previous hack to use that pin makes the GPS not work. That workaround was implemented to fix sleep issues which have now since been fixed with the state machine. This patch restores the state prior to the hack, which is known-working. Additionaly, it was discovered that M10s hate it when you try and save to non-extistent eeprom/SPI flash. This patch creates a new SAVE command for the M10 that fixes this issue. Many thanks to @MisterC925 whose report and testing was essential for this fix. fixes meshtastic#4625 Co-authored-by: Ken McGuire <[email protected]> * Remove old comments from main (meshtastic#4849) These comments were circa 4 years old. Remove them. * Try v3 * Don't run checks on workflow_dispatch * Remove native and add v4 back * Don't wait for after-checks --------- Co-authored-by: Jason Murray <[email protected]> Co-authored-by: Tom Fifield <[email protected]> Co-authored-by: Ken McGuire <[email protected]> Co-authored-by: Ben Meadors <[email protected]>
panaceya
added a commit
to mesh-mk-ua/meshtastic-firmware
that referenced
this pull request
Sep 25, 2024
* sed doesn't like newlines (meshtastic#4847) * sed doesn't like newlines * fold remove-debug-flags block * PATH is a system env var * Runners don't like rm -f ${workspace path} * chomp trailing newline (meshtastic#4848) * Fix Ublox M10 Setup (meshtastic#4842) There is no EXTINT pin available on the Tdeck, which uses the Ublox M10 GPS. Therefore our previous hack to use that pin makes the GPS not work. That workaround was implemented to fix sleep issues which have now since been fixed with the state machine. This patch restores the state prior to the hack, which is known-working. Additionaly, it was discovered that M10s hate it when you try and save to non-extistent eeprom/SPI flash. This patch creates a new SAVE command for the M10 that fixes this issue. Many thanks to @MisterC925 whose report and testing was essential for this fix. fixes meshtastic#4625 Co-authored-by: Ken McGuire <[email protected]> * Remove old comments from main (meshtastic#4849) These comments were circa 4 years old. Remove them. * Try v3 * Don't run checks on workflow_dispatch * Remove native and add v4 back * Don't wait for after-checks * Remove amd64 * Ony run on test runner label * Got the runner labels backwards * Setup python * [create-pull-request] automated change (meshtastic#4858) Co-authored-by: thebentern <[email protected]> * pip3 * pipx * No args * Update tests.yml * Pipargs * PIO script * Setup node * Consolidate commands * Who chose that ridiculous name anyway?! * Checkout should handle this but oh well * Bin path * Meshtestic submodule update * master ref * Actual ref * python3 ref * Put this back * fix meshtastic#4844 (meshtastic#4859) * Also put this back --------- Co-authored-by: Jason Murray <[email protected]> Co-authored-by: Tom Fifield <[email protected]> Co-authored-by: Ken McGuire <[email protected]> Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: thebentern <[email protected]> Co-authored-by: Thomas Göttgens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.