Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sed doesn't like newlines #4847

Merged
merged 4 commits into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .github/actions/build-variant/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ inputs:
description: Path to the build script
required: true
remove-debug-flags:
description: A newline separated list of files to remove debug flags from
description: A space separated list of files to remove debug flags from
required: false
default: ""
ota-firmware-source:
Expand Down Expand Up @@ -59,8 +59,8 @@ runs:
shell: bash
if: inputs.remove-debug-flags != ''
run: |
for PATH in ${{ inputs.remove-debug-flags }}; do
sed -i '/DDEBUG_HEAP/d' ${PATH}
for INI_FILE in ${{ inputs.remove-debug-flags }}; do
sed -i '/DDEBUG_HEAP/d' ${INI_FILE}
done
- name: Build ${{ inputs.board }}
Expand Down Expand Up @@ -88,8 +88,3 @@ runs:
overwrite: true
path: |
${{ inputs.artifact-paths }}
- name: Clean up resources
shell: bash
run: |
rm -rf .
2 changes: 1 addition & 1 deletion .github/workflows/build_esp32.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
board: ${{ inputs.board }}
remove-debug-flags: |
remove-debug-flags: >
./arch/esp32/esp32.ini
./arch/esp32/esp32s2.ini
./arch/esp32/esp32s3.ini
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_esp32_c3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
board: ${{ inputs.board }}
remove-debug-flags: |
remove-debug-flags: >
./arch/esp32/esp32.ini
./arch/esp32/esp32s2.ini
./arch/esp32/esp32s3.ini
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_esp32_s3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
board: ${{ inputs.board }}
remove-debug-flags: |
remove-debug-flags: >
./arch/esp32/esp32.ini
./arch/esp32/esp32s2.ini
./arch/esp32/esp32s3.ini
Expand Down
Loading