sed doesn't like newlines (#4847)

* sed doesn't like newlines * fold remove-debug-flags block * PATH is a system env var * Runners don't like rm -f ${workspace path}
meshtastic · Sep 24, 2024 · c72612d · c72612d
1 parent 6821335
commit c72612d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 11 deletions.
diff --git a/.github/actions/build-variant/action.yml b/.github/actions/build-variant/action.yml
@@ -12,7 +12,7 @@ inputs:
     description: Path to the build script
     required: true
   remove-debug-flags:
-    description: A newline separated list of files to remove debug flags from
+    description: A space separated list of files to remove debug flags from
     required: false
     default: ""
   ota-firmware-source:
@@ -59,8 +59,8 @@ runs:
       shell: bash
       if: inputs.remove-debug-flags != ''
       run: |
-        for PATH in ${{ inputs.remove-debug-flags }}; do
-          sed -i '/DDEBUG_HEAP/d' ${PATH}
+        for INI_FILE in ${{ inputs.remove-debug-flags }}; do
+          sed -i '/DDEBUG_HEAP/d' ${INI_FILE}
         done
 
     - name: Build ${{ inputs.board }}
@@ -88,8 +88,3 @@ runs:
         overwrite: true
         path: |
           ${{ inputs.artifact-paths }}
-
-    - name: Clean up resources
-      shell: bash
-      run: |
-        rm -rf .
diff --git a/.github/workflows/build_esp32.yml b/.github/workflows/build_esp32.yml
@@ -19,7 +19,7 @@ jobs:
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           board: ${{ inputs.board }}
-          remove-debug-flags: |
+          remove-debug-flags: >
             ./arch/esp32/esp32.ini
             ./arch/esp32/esp32s2.ini
             ./arch/esp32/esp32s3.ini

diff --git a/.github/workflows/build_esp32_c3.yml b/.github/workflows/build_esp32_c3.yml
@@ -21,7 +21,7 @@ jobs:
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           board: ${{ inputs.board }}
-          remove-debug-flags: |
+          remove-debug-flags: >
             ./arch/esp32/esp32.ini
             ./arch/esp32/esp32s2.ini
             ./arch/esp32/esp32s3.ini

diff --git a/.github/workflows/build_esp32_s3.yml b/.github/workflows/build_esp32_s3.yml
@@ -19,7 +19,7 @@ jobs:
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           board: ${{ inputs.board }}
-          remove-debug-flags: |
+          remove-debug-flags: >
             ./arch/esp32/esp32.ini
             ./arch/esp32/esp32s2.ini
             ./arch/esp32/esp32s3.ini