Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add support ansible.utils v3 #38

Closed
Tracked by #223
gotmax23 opened this issue Dec 1, 2023 · 5 comments · Fixed by ansible-community/ansible-build-data#343
Closed
Tracked by #223

Please add support ansible.utils v3 #38

gotmax23 opened this issue Dec 1, 2023 · 5 comments · Fixed by ansible-community/ansible-build-data#343

Comments

@gotmax23
Copy link

gotmax23 commented Dec 1, 2023 •
edited
Loading

cisco.meraki v2.16.16 currently pins the ansible.utils collection to v2.

dashboard-api-ansible/galaxy.yml

Line 21 in 6302dcf

ansible.utils: ">=2.0.0,<3.0"

Ansible 10, the next major version of the Ansible package will contain ansible.utils v3, so cisco.meraki will need to add support for ansible.utils v3 to remain included in the package. Ideally, the current major version of cisco.meraki could add support for ansible.utils v3 in addition to ansible.utils v2. If not, a new major version of this collection would need to be released that adds support for ansible.utils v3 and drops support for v2.

Note that Ansible 10 will not be released until next spring, so you have a bit of time, but ideally, this could be addressed sooner rather than later. Thanks for your work and for being part of the Ansible package!
@gotmax23 gotmax23 mentioned this issue Dec 1, 2023
Open
29 tasks
@felixfontein
Copy link

This is somewhat urgent since many network collections already explicitly require ansible.netcommon >= 6.0.0, which requires ansible.utils >= 3.0.0.

Ref: ansible-community/ansible-build-data#338

fmunozmiranda pushed a commit that referenced this issue Dec 4, 2023
2.16.17:
ee7c3b8 
    changes:
      bugfixes:
      - Adding support to ansible.utils >=3.0
    release_date: '2023-12-04'
  Issue #38
@fmunozmiranda
Copy link
Collaborator

Hi @felixfontein , @gotmax23 .
Support added for ansible.utils >=3.0.
Please verify and feel free to close issue if there's nothing else.

@gotmax23
Copy link
Author

gotmax23 commented Dec 5, 2023

See cisco-en-programmability/dnacenter-ansible#133 (comment).

gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue Dec 5, 2023
@gotmax23
10: pin cisco.meraki due to ansible.utils compat issues
479209c 
2.16.17 dropped support for ansible.utils v2. This change is semver
incompatible and should be reverted in the next v2 release and held
for v3, hence the two different constraints.

Relates: meraki/dashboard-api-ansible#38
gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue Dec 5, 2023
@gotmax23
9: blocklist semver-incompatible cisco.meraki
8948ce7 
We could constrain this to `<2.16.17`, but it's expected that the next
minor/patch release of cisco.meraki v2 will revert these changes

Relates: meraki/dashboard-api-ansible#38
gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue Dec 5, 2023
@gotmax23
8: blocklist semver-incompatible cisco.meraki
ec7f5e2 
We could constrain this to `<2.16.17`, but it's expected that the next
minor/patch release of cisco.meraki v2 will revert these changes

Relates: meraki/dashboard-api-ansible#38
@gotmax23 gotmax23 mentioned this issue Dec 5, 2023
Merged
felixfontein pushed a commit to ansible-community/ansible-build-data that referenced this issue Dec 5, 2023
@gotmax23
Pin cisco.dnac and cisco.meraki due to compatibility issues (#339)
2691da9 
* 10: pin cisco.dnac due to ansible.utils compat issues

6.8.2 dropped support for ansible.utils v2. This change is semver
incompatible and should be reverted in the next v6 release and held
for v7, hence the two different constraints.

* 9: blocklist semver-incompatible cisco.dnac 6.8.2

We could constrain this to `<6.8.2`, but it's expected that the next
minor/patch release of cisco.dnac v6 will revert these changes

Relates: cisco-en-programmability/dnacenter-ansible#133 (comment)

* 8: blocklist semver-incompatible cisco.dnac 6.8.2

We could constrain this to `<6.8.2`, but it's expected that the next
minor/patch release of cisco.dnac v6 will revert these changes

Relates: cisco-en-programmability/dnacenter-ansible#133 (comment)

* 10: pin cisco.meraki due to ansible.utils compat issues

2.16.17 dropped support for ansible.utils v2. This change is semver
incompatible and should be reverted in the next v2 release and held
for v3, hence the two different constraints.

Relates: meraki/dashboard-api-ansible#38

* 9: blocklist semver-incompatible cisco.meraki

We could constrain this to `<2.16.17`, but it's expected that the next
minor/patch release of cisco.meraki v2 will revert these changes

Relates: meraki/dashboard-api-ansible#38

* 8: blocklist semver-incompatible cisco.meraki

We could constrain this to `<2.16.17`, but it's expected that the next
minor/patch release of cisco.meraki v2 will revert these changes

Relates: meraki/dashboard-api-ansible#38
fmunozmiranda referenced this issue Dec 5, 2023
2.17.0:
fcb7ec4 
    changes:
      minor_changes:
        - Adding support to ansible.utils ">=2.0.0, <4.00".
    release_date: '2023-12-05'
@fmunozmiranda
Copy link
Collaborator

Ready @felixfontein @gotmax23

@gotmax23 gotmax23 mentioned this issue Dec 7, 2023
Merged
@gotmax23
Copy link
Author

gotmax23 commented Dec 7, 2023

It looks good to me now. Thanks for the quick responses and for fixing the issue! Would it be possible to do the same for https://github.com/CiscoISE/ansible-ise/?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Cisco collection constraints felixfontein/ansible-build-data
3 participants
@felixfontein @gotmax23 @fmunozmiranda