Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker] Serious collection requirements violations that require version pinning #223

Open
28 of 29 tasks
gotmax23 opened this issue Apr 27, 2023 · 29 comments
Open
28 of 29 tasks
Labels
blocker Situations which do not allow the package to be released.

Comments

@gotmax23
Copy link
Contributor

gotmax23 commented Apr 27, 2023

As per https://github.com/ansible-community/ansible-build-data/blob/main/docs/policies.md#enforcement, we need to track violations of the Repository management policies. We also need to track violations when collection dependencies conflicts arise, or collections violate semantic versioning by doing breaking changes outside of major versions. When you file an issue against a collection for violating these policies, leave a comment with a link to the issue.

@felixfontein felixfontein pinned this issue Apr 27, 2023
@gotmax23 gotmax23 added the blocker Situations which do not allow the package to be released. label May 20, 2023
@gotmax23
Copy link
Contributor Author

gotmax23 commented May 21, 2023

cyberark.pas is again violating this guideline (#235 (comment)). I filed cyberark/ansible-security-automation-collection#58.

@felixfontein felixfontein changed the title [Tracker] Collection tagging policy violations [Tracker] Serious collection requirements violations that require version pinning May 23, 2023
@felixfontein
Copy link
Contributor

felixfontein commented May 23, 2023

@felixfontein
Copy link
Contributor

hetzner.hcloud needs to be pinned to 1.11.0 in both Ansible 7 and 8 for a semantic versioning violation: ansible-collections/hetzner.hcloud#217

@felixfontein
Copy link
Contributor

There has been a new release of dellemc.enterprise_sonic (2.2.0) which reverts the breaking change and declares compatibility with ansible.netcommon >5.0.0. This fixes the problems with Ansible 8 (except that the breaking change will still be mentioned in the next porting guide, even though it is no longer a breaking change - I guess we have to add an Ansible changelog entry for that), but has the downside of not allowing this release for the next Ansible 7 release since that one has ansible.netcommon 4.x.y. So we have to keep the pin for Ansible 7 (though now it has another reason), and undo it (with a changelog entry) for Ansible 8.

@felixfontein
Copy link
Contributor

The issue with hetzner.hcloud is resolved (ansible-collections/hetzner.hcloud#217, #267).

@gotmax23
Copy link
Contributor Author

inspur.ispim 2.0.1 is not tagged in https://github.com/ispim/inspur.ispim

ispim/inspur.ispim#24

@felixfontein
Copy link
Contributor

cisco.meraki moved to a new repository: https://github.com/meraki/dashboard-api-ansible - I'll create PRs for ansible-build-data to adjust it.

@felixfontein
Copy link
Contributor

cisco.intersight was now tagged, #289 removed the ignore for the missing tags.

@gotmax23
Copy link
Contributor Author

gotmax23 commented Nov 7, 2023

@gotmax23
Copy link
Contributor Author

gotmax23 commented Nov 7, 2023

@gotmax23
Copy link
Contributor Author

gotmax23 commented Dec 1, 2023

ERROR: found collection dependency errors!
ERROR: cisco.ise 2.6.2 version_conflict: ansible.utils-3.0.0 but needs >=2.0.0,<3.0
ERROR: cisco.dnac 6.8.1 version_conflict: ansible.utils-3.0.0 but needs >=2.0.0,<3.0
ERROR: cisco.meraki 2.16.16 version_conflict: ansible.utils-3.0.0 but needs >=2.0.0,<3.0

@felixfontein
Copy link
Contributor

@felixfontein
Copy link
Contributor

@felixfontein
Copy link
Contributor

@felixfontein
Copy link
Contributor

community.ciscosmb introduced a breaking change in 1.0.8: ansible-collections/community.ciscosmb#75

@mariolenz
Copy link
Collaborator

It looks like frr.frr fails a lot of tests. I don't care about the unit tests but the failing sanity tests are problematic. I've opened ansible-collections/frr.frr#66 to let them know.

@mariolenz
Copy link
Collaborator

mariolenz commented May 21, 2024

community.grafana introduced a breaking change (removed feature) in 1.9.0: ansible-collections/community.grafana#367

@felixfontein
Copy link
Contributor

cyberark.pas 1.0.27 is not tagged: cyberark/ansible-security-automation-collection#71

@felixfontein
Copy link
Contributor

felixfontein commented Jul 4, 2024

It's too late for version pinning since 2.6.0 of that collection has been included for some months now, but FYI: CiscoDevNet/ansible-mso#479 - I've created https://forum.ansible.com/t/7039 for this.

@felixfontein
Copy link
Contributor

ansible.posix 1.6.0 has a breaking change (ansible-collections/ansible.posix#463 (comment)). #469 restricts it to < 1.6.0 for Ansible 9 and 10. For Ansible 11, we have to see what happens.

@felixfontein
Copy link
Contributor

cisco.dnac, cisco.meraki, and cisco.ise still require ansible.utils < 5.0.0 (pinned in #480 for Ansible 11).

@mariolenz
Copy link
Collaborator

cisco.dnac 6.24.0 isn't tagged: cisco-en-programmability/dnacenter-ansible#205

I suggest to wait a few days until we introduce a restriction. Maybe they'll fix this soon.

@felixfontein
Copy link
Contributor

The problem has been resolved, the release is now tagged.

@felixfontein
Copy link
Contributor

cisco.meraki 2.20.0 fails the compilation test due to bad indentation in a Python file: meraki/dashboard-api-ansible#76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Situations which do not allow the package to be released.
Projects
None yet
Development

No branches or pull requests

4 participants