Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for ansible.utils v3 #133

Closed
Tracked by #223
gotmax23 opened this issue Dec 1, 2023 · 7 comments · Fixed by ansible-community/ansible-build-data#343
Closed
Tracked by #223

Please add support for ansible.utils v3 #133

gotmax23 opened this issue Dec 1, 2023 · 7 comments · Fixed by ansible-community/ansible-build-data#343

Comments

@gotmax23
Copy link

gotmax23 commented Dec 1, 2023

Prerequisites

  • [N/A] Have you tested the operation in the API directly?
  • [N/A] Do you have the latest Ansible collection version?
  • [N/A] Review the compatibility matrix before opening an issue.

Describe the bug
cisco.dnac v6.8.1 currently pins the ansible.utils collection to v2.

ansible.utils: ">=2.0.0,<3.0"

Ansible 10, the next major version of the Ansible package will contain ansible.utils v3, so cisco.dnac will need to add support for ansible.utils v3 to remain included in the package. Ideally, the current major version of cisco.dnac could add support for ansible.utils v3 in addition to ansible.utils v2. If not, a new major version of this collection would need to be released that adds support for ansible.utils v3 and drops support for v2.

Expected behavior
N/A

Screenshots
N/A

Environment (please complete the following information):

  • Cisco DNA Center Version and patch: N/A
  • Ansible Version: 10 (in development)
  • Collection version: 6.8.1
  • OS Version: N/A

Additional context
Note that Ansible 10 will not be released until next spring, so you have a bit of time, but ideally, this could be addressed sooner rather than later. Thanks for your efforts and for being part of the Ansible package!

@felixfontein
Copy link

This is somewhat urgent since many network collections already explicitly require ansible.netcommon >= 6.0.0, which requires ansible.utils >= 3.0.0.

Ref: ansible-community/ansible-build-data#338

fmunozmiranda pushed a commit that referenced this issue Dec 4, 2023
      release_date: "2023-12-04"
      changes:
        release_summary: Changing galaxy.
        bugfixes:
          - Adding support to ansible.utils >=3.0

Issue #133
@fmunozmiranda
Copy link
Collaborator

Hi @felixfontein , @gotmax23 .
Support added for ansible.utils >=3.0.
Please verify and feel free to close issue if there's nothing else.

@gotmax23
Copy link
Author

gotmax23 commented Dec 5, 2023

It looks like 6.8.2 both dropped support for ansible.utils v2 and changed a parameter type. Both of these are breaking changes that should be reserved for a major release, but they're listed as bugfixes in the changelog.

gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue Dec 5, 2023
We could constrain this to `<6.8.2`, but it's expected that the next
minor/patch release of cisco.dnac v6 will revert these changes

Relates: cisco-en-programmability/dnacenter-ansible#133 (comment)
gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue Dec 5, 2023
We could constrain this to `<6.8.2`, but it's expected that the next
minor/patch release of cisco.dnac v6 will revert these changes

Relates: cisco-en-programmability/dnacenter-ansible#133 (comment)
@felixfontein
Copy link

The parameter type change is possibly OK, assuming that it was not possible to use the parameter before (if the API rejected the value since it had the wrong type). Only if it was possible to successfully run the module when specifying a non-trivial value for that parameter before, then it is a breaking change.

felixfontein pushed a commit to ansible-community/ansible-build-data that referenced this issue Dec 5, 2023
* 10: pin cisco.dnac due to ansible.utils compat issues

6.8.2 dropped support for ansible.utils v2. This change is semver
incompatible and should be reverted in the next v6 release and held
for v7, hence the two different constraints.

* 9: blocklist semver-incompatible cisco.dnac 6.8.2

We could constrain this to `<6.8.2`, but it's expected that the next
minor/patch release of cisco.dnac v6 will revert these changes

Relates: cisco-en-programmability/dnacenter-ansible#133 (comment)

* 8: blocklist semver-incompatible cisco.dnac 6.8.2

We could constrain this to `<6.8.2`, but it's expected that the next
minor/patch release of cisco.dnac v6 will revert these changes

Relates: cisco-en-programmability/dnacenter-ansible#133 (comment)

* 10: pin cisco.meraki due to ansible.utils compat issues

2.16.17 dropped support for ansible.utils v2. This change is semver
incompatible and should be reverted in the next v2 release and held
for v3, hence the two different constraints.

Relates: meraki/dashboard-api-ansible#38

* 9: blocklist semver-incompatible cisco.meraki

We could constrain this to `<2.16.17`, but it's expected that the next
minor/patch release of cisco.meraki v2 will revert these changes

Relates: meraki/dashboard-api-ansible#38

* 8: blocklist semver-incompatible cisco.meraki

We could constrain this to `<2.16.17`, but it's expected that the next
minor/patch release of cisco.meraki v2 will revert these changes

Relates: meraki/dashboard-api-ansible#38
@fmunozmiranda
Copy link
Collaborator

@felixfontein are you agree if 6.9.0 is released with ansible.utils: ">=2.0.0,<4.0", with that we don't drop support for v2 a add support for v3?

@gotmax23
Copy link
Author

gotmax23 commented Dec 5, 2023

are you agree if 6.9.0 is released with ansible.utils: ">=2.0.0,<4.0", with that we don't drop support for v2 a add support for v3?

Yes, that would be great!

This was referenced Dec 5, 2023
@fmunozmiranda
Copy link
Collaborator

Ready @felixfontein @gotmax23

bvargasre pushed a commit that referenced this issue Feb 5, 2024
Added the compatibility to update specific credential/info of list of…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants