Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue where TypeError is thrown by SQLConnector cookiecutter implementation due to super() references #972

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Sep 15, 2022

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #972 (9e98a97) into main (aab68a1) will increase coverage by 0.59%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
+ Coverage   81.18%   81.77%   +0.59%     
==========================================
  Files          36       37       +1     
  Lines        3555     3742     +187     
  Branches      718      746      +28     
==========================================
+ Hits         2886     3060     +174     
- Misses        492      500       +8     
- Partials      177      182       +5     
Impacted Files Coverage Δ
singer_sdk/io_base.py 76.47% <66.66%> (-1.31%) ⬇️
singer_sdk/mapper_base.py 56.14% <66.66%> (+0.58%) ⬆️
singer_sdk/sinks/sql.py 78.48% <80.00%> (-0.47%) ⬇️
singer_sdk/helpers/_batch.py 90.38% <90.38%> (ø)
singer_sdk/sinks/core.py 80.13% <90.90%> (+1.39%) ⬆️
singer_sdk/streams/core.py 83.25% <92.06%> (+1.87%) ⬆️
singer_sdk/helpers/_singer.py 96.59% <100.00%> (+0.17%) ⬆️
singer_sdk/target_base.py 85.37% <100.00%> (+0.35%) ⬆️
singer_sdk/streams/rest.py 83.87% <0.00%> (+1.29%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon merged commit f74493d into main Sep 15, 2022
@edgarrmondragon edgarrmondragon deleted the kgpayne/issue967 branch September 15, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeError thrown by SQLConnector child class generated by cookie cutter
2 participants