Skip to content

Commit

Permalink
fix: resolve issue where TypeError is thrown by SQLConnector cookiecu…
Browse files Browse the repository at this point in the history
…tter implementation due to super() references (#972)

replace super() with direct class references
  • Loading branch information
Ken Payne authored Sep 15, 2022
1 parent 5bab2d8 commit f74493d
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ class {{ cookiecutter.source_name }}Connector(SQLConnector):
Developers may optionally add custom logic before calling the default
implementation inherited from the base class.
"""
# Optionally, add custom logic before calling the super().
# Optionally, add custom logic before calling the parent SQLConnector method.
# You may delete this method if overrides are not needed.
return super().to_jsonschema_type(sql_type)
return SQLConnector.to_jsonschema_type(sql_type)

@staticmethod
def to_sql_type(jsonschema_type: dict) -> sqlalchemy.types.TypeEngine:
Expand All @@ -40,9 +40,9 @@ class {{ cookiecutter.source_name }}Connector(SQLConnector):
Developers may optionally add custom logic before calling the default
implementation inherited from the base class.
"""
# Optionally, add custom logic before calling the super().
# Optionally, add custom logic before calling the parent SQLConnector method.
# You may delete this method if overrides are not needed.
return super().to_sql_type(jsonschema_type)
return SQLConnector.to_sql_type(jsonschema_type)


class {{ cookiecutter.source_name }}Stream(SQLStream):
Expand Down

0 comments on commit f74493d

Please sign in to comment.