Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue where TypeError is thrown by SQLConnector cookiecutter implementation due to super() references #972

Merged
merged 2 commits into from
Sep 15, 2022
Merged

fix: resolve issue where TypeError is thrown by SQLConnector cookiecutter implementation due to super() references #972

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f7b6ee
replace super() with direct class references
Sep 15, 2022
9e98a97
Merge branch 'main' into kgpayne/issue967
Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...{{cookiecutter.library_name}}/{%if 'SQL' == cookiecutter.stream_type %}client.py{%endif%}
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ class {{ cookiecutter.source_name }}Connector(SQLConnector):
Developers may optionally add custom logic before calling the default
implementation inherited from the base class.
"""
# Optionally, add custom logic before calling the super().
# Optionally, add custom logic before calling the parent SQLConnector method.
# You may delete this method if overrides are not needed.
return super().to_jsonschema_type(sql_type)
return SQLConnector.to_jsonschema_type(sql_type)

@staticmethod
def to_sql_type(jsonschema_type: dict) -> sqlalchemy.types.TypeEngine:
Expand All @@ -40,9 +40,9 @@ class {{ cookiecutter.source_name }}Connector(SQLConnector):
Developers may optionally add custom logic before calling the default
implementation inherited from the base class.
"""
# Optionally, add custom logic before calling the super().
# Optionally, add custom logic before calling the parent SQLConnector method.
# You may delete this method if overrides are not needed.
return super().to_sql_type(jsonschema_type)
return SQLConnector.to_sql_type(jsonschema_type)


class {{ cookiecutter.source_name }}Stream(SQLStream):
Expand Down