Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the csv_delimiter #455

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Add the csv_delimiter #455

merged 1 commit into from
Apr 3, 2023

Conversation

bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Mar 29, 2023

As per the specification: meilisearch/specifications#223

You can now specify a csv_delimiter when using add_or_replace_unchecked_payload and add_or_update_unchecked_payload.

If your payload is in csv, it is used to know how the values are separated.

@bidoubiwa bidoubiwa changed the title Merge branch 'bump-meilisearch-v1.1.0' of github.com:meilisearch/meil… Add the csv_delimiter Mar 29, 2023
@bidoubiwa bidoubiwa marked this pull request as ready for review March 29, 2023 10:09
@bidoubiwa bidoubiwa added the enhancement New feature or request label Mar 29, 2023
@bidoubiwa bidoubiwa force-pushed the add_csv_delimiter branch 2 times, most recently from 9783557 to 2bd8f5b Compare March 29, 2023 11:06
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, 🐗
bors merge

bors bot added a commit that referenced this pull request Mar 29, 2023
455: Add the csv_delimiter r=irevoire a=bidoubiwa

As per the specification: meilisearch/specifications#223

You can now specify a `csv_delimiter` when using `add_or_replace_unchecked_payload` and  `add_or_update_unchecked_payload`. 

If your payload is in `csv`, it is used to know how the values are separated.

Co-authored-by: Charlotte Vermandel <[email protected]>
@bidoubiwa
Copy link
Contributor Author

bors r-

@bors
Copy link
Contributor

bors bot commented Mar 29, 2023

Canceled.

@irevoire
Copy link
Member

bors cancel

@bidoubiwa bidoubiwa added breaking-change The related changes are breaking for the users and removed enhancement New feature or request labels Mar 29, 2023
@bidoubiwa
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Apr 3, 2023
456: Update version for the next release (v0.23.0) r=bidoubiwa a=meili-bot

This version makes this package compatible with Meilisearch v1.1 🎉
Check out the changelog of [Meilisearch v1.1](https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0) for more information on the changes.

## 🚀 Enhancements
* Add the `multi_search` method on `Client` #454

## ⚠️ Breaking changes

* Rename `Document` trait to `IndexConfig` and extend with function to retrieve index (#445) `@amaihoefner`
* Add facetstats in the searchResults #443 
* Add a new `csv_delimiter` parameter on `index.add_or_replace_unchecked_payload` and `index. add_or_update_unchecked_payload` #455

Thanks again to `@amaihoefner,`  and `@shimatar0!` 🎉


Co-authored-by: meili-bot <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 3, 2023

Build succeeded:

@bors bors bot merged commit 73bc848 into bump-meilisearch-v1.1.0 Apr 3, 2023
@bors bors bot deleted the add_csv_delimiter branch April 3, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants