Add facetstats in the searchResults #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
442: Failing tests due to breaking patch in mockito r=irevoire a=bidoubiwa Mockito released a [new patch version](https://github.com/lipanski/mockito/releases/tag/0.32.5) messing with the asynchronousity methods. Due to that, the tests were panicking in the other PR's. Since additionally to that I received a lot of warning from the library saying that the methods we were using are deprecated, I updated mockito to its v1 version. Co-authored-by: Charlotte Vermandel <[email protected]>
…ump-meilisearch-v1.1.0
bidoubiwa
added
the
breaking-change
alallema
reviewed
Mar 20, 2023
| outer_fn | ||
| .attrs | ||
| .push(parse_quote!(#[futures_await_test::async_test])); | ||
| outer_fn.attrs.push(parse_quote!(#[tokio::test])); |
There was a problem hiding this comment.
Its the library used to handle async testing. We had to change it to be compatible with the new version of Mockito
bidoubiwa
changed the title
bidoubiwa
changed the title
bors bot
added a commit
that referenced
this pull request
Apr 3, 2023
456: Update version for the next release (v0.23.0) r=bidoubiwa a=meili-bot This version makes this package compatible with Meilisearch v1.1 🎉 Check out the changelog of [Meilisearch v1.1](https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0) for more information on the changes. ## 🚀 Enhancements * Add the `multi_search` method on `Client` #454 ##⚠️ Breaking changes * Rename `Document` trait to `IndexConfig` and extend with function to retrieve index (#445) `@amaihoefner` * Add facetstats in the searchResults #443 * Add a new `csv_delimiter` parameter on `index.add_or_replace_unchecked_payload` and `index. add_or_update_unchecked_payload` #455 Thanks again to `@amaihoefner,` and `@shimatar0!` 🎉 Co-authored-by: meili-bot <[email protected]>
bidoubiwa
added a commit
that referenced
this pull request
Apr 3, 2023
* Failing tests due to breaking patch in mockito * Add facetstats for Meilisearch v1.1.0 * Update src/tasks.rs --------- Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
facetStatstype in theSearchResultsstructure. It introduces min max values for numeric facet that have been required through the search parameter facetAs per the specification
SDK requirements: meilisearch/integration-guides#251