Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Document trait to IndexConfig and extend with function to retrieve index #445

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

amaihoefner
Copy link
Contributor

@amaihoefner amaihoefner commented Mar 15, 2023

Pull Request

Related issue

Fixes #444

What does this PR do?

  • rename Document trait to IndexConfig
  • add constant IndexConfig::INDEX_STR to store name of the index
  • add IndexConfig::index function to provide easier and safer access to index

PR checklist

Please check if your PR fulfills the following requirements:

  • [ x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [ x] Have you read the contributing guidelines?
  • [ x] Have you made sure that the title is accurate and descriptive of the changes?

@bidoubiwa bidoubiwa self-requested a review March 20, 2023 11:17
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #444

@amaihoefner amaihoefner marked this pull request as ready for review March 20, 2023 12:45
examples/web_app/src/document.rs Outdated Show resolved Hide resolved
src/dumps.rs Outdated Show resolved Hide resolved
@bidoubiwa
Copy link
Contributor

Only thing missing is updating the title and the body of the PR. After that it can be released :)

@amaihoefner amaihoefner changed the title Extend Document trait with function to get index Rename Document trait to IndexConfig and extend with function to retrieve index Mar 27, 2023
@bidoubiwa bidoubiwa added the breaking-change The related changes are breaking for the users label Mar 28, 2023
@bidoubiwa
Copy link
Contributor

bors merge

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 🙏

@bors
Copy link
Contributor

bors bot commented Mar 28, 2023

@bors bors bot merged commit 9787c57 into meilisearch:main Mar 28, 2023
bors bot added a commit that referenced this pull request Apr 3, 2023
456: Update version for the next release (v0.23.0) r=bidoubiwa a=meili-bot

This version makes this package compatible with Meilisearch v1.1 🎉
Check out the changelog of [Meilisearch v1.1](https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0) for more information on the changes.

## 🚀 Enhancements
* Add the `multi_search` method on `Client` #454

## ⚠️ Breaking changes

* Rename `Document` trait to `IndexConfig` and extend with function to retrieve index (#445) `@amaihoefner`
* Add facetstats in the searchResults #443 
* Add a new `csv_delimiter` parameter on `index.add_or_replace_unchecked_payload` and `index. add_or_update_unchecked_payload` #455

Thanks again to `@amaihoefner,`  and `@shimatar0!` 🎉


Co-authored-by: meili-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Document trait with function to get index
2 participants