Implement faceting in search #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
curquiza
commented
Jun 4, 2020
•
curquiza
commented
- Fixes Search parametters don't accept lists of strings (and should) #41 (close the PR Fix bug: Search params crash when they are a list of strings #42 in favor of this one)
- There are not enough tests for the search, I opened an issue Improve search tests #45
- There is still the 3 same tests failing since MeiliSearch is broken
curquiza
force-pushed
the
facets-in-search
branch
2 times, most recently
from
19807d3
to
ad114ce
Compare
curquiza
force-pushed
the
facets-in-search
branch
from
ad114ce
to
39b3099
Compare
eskombro
requested changes
Jun 4, 2020
Co-authored-by: Samuel Jimenez <[email protected]>
Co-authored-by: Samuel Jimenez <[email protected]>
Co-authored-by: Samuel Jimenez <[email protected]>
Co-authored-by: Samuel Jimenez <[email protected]>
Co-authored-by: Samuel Jimenez <[email protected]>
|
@eskombro you're completely right! I added my new test too fast 🙈! |
curquiza
added a commit
that referenced
this pull request
Jun 15, 2020
* Rename fields_frequency to fields_distribution according to MeiliSearch v0.11 * Add method to use faceting sub routes (#44) * Implement faceting in search (#46) * Implement faceting in search * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> Co-authored-by: Samuel Jimenez <[email protected]> * Upd tests according to change in MeiliSearch about anthentication (#48) * Add debugging part in README * Add test with multiple facetFilters (#51) * Change create_index prototype (#50) Co-authored-by: Samuel Jimenez <[email protected]>
bidoubiwa
pushed a commit
that referenced
this pull request
Mar 8, 2021
* Rename fields_frequency to fields_distribution according to MeiliSearch v0.11 * Add method to use faceting sub routes (#44) * Implement faceting in search (#46) * Implement faceting in search * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> Co-authored-by: Samuel Jimenez <[email protected]> * Upd tests according to change in MeiliSearch about anthentication (#48) * Add debugging part in README * Add test with multiple facetFilters (#51) * Change create_index prototype (#50) Co-authored-by: Samuel Jimenez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.