Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search tests #45

Closed
2 tasks
curquiza opened this issue Jun 4, 2020 · 5 comments
Closed
2 tasks

Improve search tests #45

curquiza opened this issue Jun 4, 2020 · 5 comments
Assignees
Labels

Comments

@curquiza
Copy link
Member

curquiza commented Jun 4, 2020

Add more tests for the search methods.

  • Test, at least, each search parameter individually.
  • add, if possible, more "multiple search parameters" example.

Could be done in multiple PR of course 🙂

@eskombro eskombro changed the title Improve search part Improve search tests and examples in README Jun 4, 2020
@curquiza curquiza changed the title Improve search tests and examples in README Improve search tests Jun 6, 2020
@gczh
Copy link
Contributor

gczh commented Oct 1, 2020

I'm keen to work on this! 🙈

@curquiza
Copy link
Member Author

curquiza commented Oct 1, 2020

Awesome! I assign you! Thanks 😁

@curquiza
Copy link
Member Author

curquiza commented Nov 3, 2020

Hello @gczh, I'm going to change the issue assignment, if you are ok with this 🙂
@CaroFG is joining the Meili team and this issue would be a really good start 🚀
Of course, feel free to review the PR, and after that, add all the tests you wish. It's indeed complicated to be exhaustive when it's related to testing so any addition would be more than welcome.

@curquiza curquiza assigned CaroFG and unassigned gczh Nov 3, 2020
@gczh
Copy link
Contributor

gczh commented Nov 3, 2020 via email

@curquiza
Copy link
Member Author

Closed by #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants