-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to use faceting sub routes #44
Conversation
13174cd
to
ba6a359
Compare
bca17b5
to
c410b4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I test your PR and get 7 failing tests.
My testing steps:
For MeiliSearch
- Pull origin master du repo
meilisearch
- cargo build --release
- ./target/release/meilisearch --master-key=masterKey
For meilisearch-ruby
- git pull origin master
- git checkout add-facets-settings-routes
- bundle exec rspec
Finished in 8.91 seconds (files took 0.42274 seconds to load)
115 examples, 7 failures
Failed examples:
rspec ./spec/meilisearch/index/documents_spec.rb:65 # MeiliSearch::Index - Documents All basic tests with primary-key inference browses documents with query parameters
rspec ./spec/meilisearch/index/settings_spec.rb:43 # MeiliSearch::Index - Settings On global settings routes gets default values of settings
rspec ./spec/meilisearch/index/settings_spec.rb:410 # MeiliSearch::Index - Settings On attributes-for-faceting sub-routes gets default values of attributes for faceting
rspec ./spec/meilisearch/index/settings_spec.rb:416 # MeiliSearch::Index - Settings On attributes-for-faceting sub-routes updates attributes for faceting
rspec ./spec/meilisearch/index/settings_spec.rb:423 # MeiliSearch::Index - Settings On attributes-for-faceting sub-routes resets attributes for faceting
rspec ./spec/meilisearch/index/settings_spec.rb:442 # MeiliSearch::Index - Settings Index with primary-key gets the default values of settings
rspec ./spec/meilisearch/index/stats_spec.rb:35 # MeiliSearch::Index - Stats gets the distribution of fields
Coverage report generated for RSpec to /Users/esk/Meili/meilisearch-ruby/coverage. 869 / 892 LOC (97.42%) covered.
SimpleCov failed with exit 1
Seems like basic tests like doing a simple search request with an offset is not working 😞
@eskombro |
Nothing, same :/ |
Ok, got 3 Failures 🥳 :
As you said, those arre waiting for fixes from MeiliSearch. Your code and tests look good to me tho 🎉 |
I put those issues here to keep track: meilisearch/meilisearch#742 @curquiza correct me if I'm wrong please :) |
ba6a359
to
8e809fe
Compare
c410b4f
to
432c1b1
Compare
432c1b1
to
d299941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* Rename fields_frequency to fields_distribution according to MeiliSearch v0.11 * Add method to use faceting sub routes (#44) * Implement faceting in search (#46) * Implement faceting in search * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> Co-authored-by: Samuel Jimenez <[email protected]> * Upd tests according to change in MeiliSearch about anthentication (#48) * Add debugging part in README * Add test with multiple facetFilters (#51) * Change create_index prototype (#50) Co-authored-by: Samuel Jimenez <[email protected]>
* Rename fields_frequency to fields_distribution according to MeiliSearch v0.11 * Add method to use faceting sub routes (#44) * Implement faceting in search (#46) * Implement faceting in search * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> * Update spec/meilisearch/index/search_spec.rb Co-authored-by: Samuel Jimenez <[email protected]> Co-authored-by: Samuel Jimenez <[email protected]> * Upd tests according to change in MeiliSearch about anthentication (#48) * Add debugging part in README * Add test with multiple facetFilters (#51) * Change create_index prototype (#50) Co-authored-by: Samuel Jimenez <[email protected]>
NB: tests do not run yet because the v0.11 is not out.
If you want to run the tests with the last version of MeiliSearch, use
cargo
in the MeiliSearch repo, and go on my branch.