Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to the next Meilisearch release (v0.28.0) #403

Merged
merged 81 commits into from
Jan 17, 2023

Conversation

meili-bot
Copy link
Contributor

@meili-bot meili-bot commented Jun 9, 2022

Related to this issue: meilisearch/integration-guides#205

This PR:

  • gathers the changes related to the next Meilisearch release (v0.28.0) so that this package is ready when the official release is out.
  • should pass the tests against the latest pre-release of Meilisearch.
  • might eventually contain test failures until the Meilisearch v0.28.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.28.0) is out.

This PR is auto-generated for the pre-release week purpose.

Done:

@alallema alallema mentioned this pull request Aug 2, 2022
@alallema alallema marked this pull request as ready for review December 28, 2022 11:31
@alallema alallema marked this pull request as draft December 28, 2022 11:31
@alallema alallema marked this pull request as ready for review January 5, 2023 18:07
@alallema alallema requested a review from brunoocasali January 5, 2023 18:07
brunoocasali
brunoocasali previously approved these changes Jan 16, 2023
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect perfect! 🌮

Code samples changes related to Meilisearch release (v0.28.0)
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

Comment on lines +20 to +21
protected int estimatedTotalHits;
protected Object facetDistribution;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing nbHits here and making the changes on facetDistribution?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?
meilisearch/meilisearch#2376

@alallema alallema merged commit e59607e into main Jan 17, 2023
@alallema alallema deleted the bump-meilisearch-v0.28.0 branch January 17, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants