Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor handlers for the usage of URLBuilder #524

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Refactor handlers for the usage of URLBuilder #524

merged 2 commits into from
Jan 10, 2023

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Jan 10, 2023 •
edited
Loading

  • Creation of the class DocumentQuery to getting one document.

Notes:

  • A function has been created in each handler to avoid instantiating a single new URLBuilder() in the class parameters.

@alallema alallema requested a review from brunoocasali January 10, 2023 15:27
brunoocasali
brunoocasali approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion but feel free to ignore it.

Nice work!

src/main/java/com/meilisearch/sdk/http/URLBuilder.java Outdated Show resolved Hide resolved
@alallema alallema merged commit ec11162 into bump-meilisearch-v0.28.0 Jan 10, 2023
@alallema alallema deleted the refactor_url-builder branch January 10, 2023 19:15
@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alallema @brunoocasali