Apply tasks changes #510
Merged
Apply tasks changes #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
force-pushed
the
tasks_changes
branch
from
57340a3 to
235276c
Compare
| } | ||
|
|
||
| /** | ||
| * Retrieves tasks from the client | ||
| * Retrieves all TasksHandler at the specified index uid |
There was a problem hiding this comment.
Not sure if I got this... 👀
There was a problem hiding this comment.
I modify it's better?
There was a problem hiding this comment.
What I found strange was the TasksHandler part. Maybe you want to Retrieves all tasks at the specified index uid
| * @throws MeilisearchException if client request causes an error | ||
| */ | ||
| TasksResults getTasks(String indexUid, TasksQuery param) throws MeilisearchException { | ||
| String[] newIndexUid = new String[param.getIndexUid().length + 1]; |
There was a problem hiding this comment.
I'm not sure why you had to do this. Can you explain it to me, please?
There was a problem hiding this comment.
It's for this specific case:
TasksQuery query = new TasksQuery().setIndexes(new String[] {"books", "cities"});
client.index("movies").getTasks();In case the getTasks() method is called through the IndexesHandler the request of this should be:
/tasks?indexUids=movies,books,cities
| * @throws MeilisearchException if the client request causes an error | ||
| */ | ||
| Task addDocuments(String uid, String document, String primaryKey) throws MeilisearchException { | ||
| TaskInfo addDocuments(String uid, String document, String primaryKey) | ||
| throws MeilisearchException { | ||
| String urlQuery = "/indexes/" + uid + "/documents"; |
There was a problem hiding this comment.
You can apply the URLBuilder here :)
There was a problem hiding this comment.
Yes this one will be changed during PR about documents changes
brunoocasali
added
the
breaking-change
alallema
force-pushed
the
tasks_changes
branch
2 times, most recently
from
11ce64d to
d177640
Compare
alallema
force-pushed
the
tasks_changes
branch
from
d177640 to
6e8f0e2
Compare
alallema
force-pushed
the
tasks_changes
branch
2 times, most recently
from
fd81b25 to
ebb17dc
Compare
alallema
force-pushed
the
tasks_changes
branch
from
ebb17dc to
5162345
Compare
alallema
force-pushed
the
tasks_changes
branch
from
5162345 to
67556ac
Compare
brunoocasali
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related to: meilisearch/integration-guides#205
What does this PR do?
Breaking because enforces the users to use Meilisearch v0.28.0
Changes
GET /indexes/:indexUid/tasks. UseGET /tasks?indexUid=:indexUidinstead.GET /indexes/:indexUid/tasks/:taskUid. UseGET /tasks/:taskUidinstead.GET /taskswe can filter by:type,statusandindexUid.statuslike this:enqueued,processing.index.getTasknow useGET /tasks/:task_uidindex.getTasksnow useGET/tasks?indexUid=moviesuidfield totaskUid.index.getTasksaccept pagination metadata, added limit (default: 20), from.client.getTasksaccept pagination metadata, added limit (default: 20), from.TaskInfoclass to handle all response from asynchronous operationTasksQueryclass to handle pagination filteringTasksResultsclass to retrieve responses fromgetTasks