The value from jr:choice-name() can be stale

[abbyad]

The value from a jr:choice-name() calculation is stale if the choice label is changed but the choice value is not. The choice-name function should be rerun if either the choice value or label are changed.

Will post test form shortly.

[abbyad]

Test form, which is also temporarily accessible here:

<?xml version="1.0"?>
<h:html xmlns="http://www.w3.org/2002/xforms" xmlns:ev="http://www.w3.org/2001/xml-events" xmlns:h="http://www.w3.org/1999/xhtml" xmlns:jr="http://openrosa.org/javarosa" xmlns:orx="http://openrosa.org/xforms" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <h:head>
    <h:title>Test Issue 3281</h:title>
    <model>
      <instance>
        <issue-3281 delimiter="#" id="issue_3281" prefix="J1!issue_3281!" version="2017-03-24">
          <input>Default Value</input>
          <translator>clinic</translator><output/><debug/>
          <note/>
          <meta>
            <instanceID/>
          </meta>
        </issue-3281>
      </instance>
      <bind nodeset="/issue-3281/input" type="string"/>
      <bind nodeset="/issue-3281/translator" type="select1"/>
      <bind calculate="jr:choice-name( /issue-3281/translator ,' /issue-3281/translator ')" nodeset="/issue-3281/output" type="string"/>
      <bind nodeset="/issue-3281/debug" readonly="true()" type="string"/>
      <bind nodeset="/issue-3281/note" readonly="true()" type="string"/>
      <bind calculate="concat('uuid:', uuid())" nodeset="/issue-3281/meta/instanceID" readonly="true()" type="string"/>
    </model>
  </h:head>
  <h:body>
    <input ref="/issue-3281/input">
      <label>Input</label>
    </input>
    <select1 ref="/issue-3281/translator">
      <label>Translator</label>
      <item>
        <label>[<output value=" /issue-3281/input "/>] District</label>
        <value>district_hospital</value>
      </item>
      <item>
        <label>[<output value=" /issue-3281/input "/>] Health Center</label>
        <value>health_center</value>
      </item>
      <item>
        <label>[<output value=" /issue-3281/input "/>] Area</label>
        <value>clinic</value>
      </item>
    </select1>
    <input ref="/issue-3281/debug">
      <label>jr:choice-name($ {translator},'$ {translator}') = **<output value=" /issue-3281/output "/>**</label>
    </input>
    <input ref="/issue-3281/note">
      <label>The value above is stale if _Input_ is changed and you leave the textbox since it modifies the choice label for _Translator_ but not the value. The choice-name function gets updated if the choice value is modified, but should also update if the choice label changes.</label>
    </input>
  </h:body>
</h:html>

Tested on 2.10.1

[alxndrsn]

Required by 2017-03-30.

[alxndrsn]

medic-enketo-0.9.2 released to fix this; upstream PR at enketo/enketo-core#414

[abbyad]

Seems to be working well in 2.10.3-beta. Moving to Ready.