This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Trigger calcUpdate() calls for changes to option labels #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes enketo/enketo#370
This is a fix for the example form shown in enketo/enketo#370
I'm not convinced this is safe or optimal for a few reasons:
jr:choice-name, but don't use.option-wrappercalcUpdate()should be calculated, but cutting the form name off the front of the fully-qualified xpath to the model element seems to work (owName.substring( owName.indexOf( '/', 1 ) ))<output>can occur within.option-wrapperbut outside an option label, in which casecalcUpdate()will be triggered needlesslyPerhaps if nothing else, this fix will give a clearer insight into what the bug in #410 really is!