Find alternative for jr:choice-name or re-implement support for it

[alxndrsn]

As per enketo/enketo#370, we should either find an alternative way to implement our jr:choice-name() calls, or write an adapter to support it properly in enketo-core.

@abbyad it would help if you can explain the current use of jr:choice-name() in our forms. We have it in 83 different forms currently 🙂

[abbyad]

There are a couple of ways we are using jr:choice-name().

Show or save label (not value)

Show the user the choice they made earlier in the form as part of the Summary page. Without the jr:choice-name() function the potential workaround is to have a calculate converting the value back to a nice label... but this is difficult to manage and would not work with multiple languages (eg in Standard).

Build SMS

Build an outgoing SMS message within the form using values retrieved in the form, that can work in multiple languages and be edited in the form.

Summary page

[alxndrsn]

Thanks! Note to self: specifically we're trying to avoid uses as per enketo/enketo#370

[alxndrsn]

It sounds like this would be worth the effort of fixing with enketo-core's latest release, using external overrides of functionality. This means that we should not need to release our own version and should not need to "monkey patch" our node modules, making future upgrades much simpler.

[garethbowen]

@alxndrsn Some thoughts, back to you!

[abbyad]

@alxndrsn what version is this available in? If it is only in 2.14 I will wait for a beta of that to do AT.

[alxndrsn]

Yeah, AFAIK this is 2.14 onwards.

[sglangevin]

This should be AT-ed on master. 2.14 has not yet been branched from master, so anything in master is going to be part of 2.14.

[abbyad]

Perfect, I'll test this on alpha.dev

[sglangevin]

@abbyad has this been sufficiently tested or it needs more?

[abbyad]

I have not tested yet as part of this issue, but was tested with #3870 as part of 2.13.

@alxndrsn, has anything changed here for 2.14?

[alxndrsn]

Should be the same for 2.14. Probably worth checking, though!

[sglangevin]

@abbyad what is the status of AT on this issue?

[abbyad]

We should retest this on 2.14 to verify that it works as it does on 2.13. I am planning on doing that as part of my next round of AT for 2.14, likely today, but anyone else is free to take this on.

[abbyad]

Works well in 2.14. Tested with the form from #3281 (comment) but using <h:body class="pages"> since the value is stale until page turns.