fix(bcd): Fix version range in production #7614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
|
Note: clashes with #7612 |
danielhjacobs
force-pushed
the
prod_earlier_version_removed
branch
from
5d04537 to
29872a3
Compare
caugner
requested changes
Nov 18, 2022
client/src/document/ingredients/browser-compatibility-table/feature-row.tsx
Outdated
Show resolved
Hide resolved
caugner
changed the title
Don't worry about that one, I'll have to redo that one anyways, as I mixed different aspects into a single commit, making it un-reviewable. |
|
Changed |
danielhjacobs
force-pushed
the
prod_earlier_version_removed
branch
from
9a9b4b4 to
8cd4627
Compare
danielhjacobs
force-pushed
the
prod_earlier_version_removed
branch
from
8cd4627 to
976aeb5
Compare
caugner
added
the
browser-compat
danielhjacobs
force-pushed
the
prod_earlier_version_removed
branch
from
976aeb5 to
c65ab2f
Compare
github-actions
bot
removed
the
browser-compat
|
Sorry, force-pushed to fix comment. |
caugner
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6667 on prod
Problem
See #7589 (comment)
Solution
Put
version_last(version before version_removed when version_removed is a string) in BCD info in document-extractor. Then show it in BCD version range.Screenshots
No difference compared to #7589
How did you test this change?
yarn build