refactor(build): split up document-extractor #7612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dev build for 037fa35 was deployed to: https://pr7612.content.dev.mdn.mozit.cloud/ |
LGTM. |
This was referenced Nov 17, 2022
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
caugner
force-pushed
the
split-up-document-extractor
branch
from
037fa35 to
6ff69b9
Compare
github-actions
bot
removed
the
merge conflicts 🚧
caugner
force-pushed
the
split-up-document-extractor
branch
from
6ff69b9 to
6264679
Compare
caugner
force-pushed
the
split-up-document-extractor
branch
from
6264679 to
1fb3f94
Compare
caugner
force-pushed
the
split-up-document-extractor
branch
from
1fb3f94 to
aafc160
Compare
|
Dev build for aafc160 was deployed to: https://pr7612.content.dev.mdn.mozit.cloud/ |
LGTM:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Splits up the
build/document-extractor.tsinto individual files.Problem
The
document-extractorhas 833 lines and extracts multiple things that don't need to be together.Solution
Split it up into multiple
extract-*files.Screenshots
n/a
How did you test this change?
Not yet, looking at the test workflow first.