Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCD tables include the version_removed in the version range #6667

Closed
foolip opened this issue Feb 5, 2021 · 6 comments · Fixed by #7589 or #7614
Closed

BCD tables include the version_removed in the version range #6667

foolip opened this issue Feb 5, 2021 · 6 comments · Fixed by #7589 or #7614
Labels
accepting PR We invite you to open a PR to resolve this issue. browser-compat issues related to the browser compatibility data tables (BCD) p3 We don't have visibility when this will be addressed. ux make the user experience awesome

Comments

@foolip
Copy link
Contributor

foolip commented Feb 5, 2021

This is https://bugzilla.mozilla.org/show_bug.cgi?id=1417902 filed again for the new MDN setup.

The problem is clearly illustrated by things that were in EdgeHTML (Edge 12-18) but are not in new Chromium-based Edge 79+:
https://developer.mozilla.org/en-US/docs/Web/API/DocumentType#browser_compatibility

It looks as though support was in Edge 12-79, but it was in Edge 12-18.


From duplicate #3971:

Take a look at this table:
https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent/replacesClientId#browser_compatibility

The data for Edge being rendered here is:

"edge": {
  "version_added": "18",
  "version_removed": "79"
},

This is rendered as "18 — 79" on a red background. I think the natural interpretation of this that the feature was in versions 18-79, but the correct interpretation is that it was in Edge 18 only.

I think the logic here should be:

  • The displayed end range is the version before version_removed in BCD.
  • If that is the same as the start range, show just a single number on red, "18" in this case.
@Rumyra Rumyra added needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. enhancement Improves an existing feature. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jun 7, 2021
@github-actions github-actions bot added the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Apr 17, 2022
@Elchi3
Copy link
Member

Elchi3 commented Apr 27, 2022

This should probably be a Yari issue.

@github-actions github-actions bot removed the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Apr 27, 2022
@sideshowbarker sideshowbarker transferred this issue from mdn/content Jul 6, 2022
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 6, 2022
@github-actions github-actions bot added the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Aug 12, 2022
@caugner
Copy link
Contributor

caugner commented Nov 14, 2022

It looks as though support was in Edge 12-79, but it was in Edge 12-18.

According to browser-compat-data, DocumentType was added in Edge 12 and removed in Edge 79.

@foolip Is this issue about showing 12-78 instead of 12-79, as Edge 78 is the last version that supported the feature? In the issue description, you mention Edge 12-18, which sounds like this is also a data issue? Or is 18 just a typo?

@caugner caugner added p3 We don't have visibility when this will be addressed. ux make the user experience awesome browser-compat issues related to the browser compatibility data tables (BCD) and removed enhancement Improves an existing feature. needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Nov 14, 2022
@github-actions github-actions bot removed the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Nov 14, 2022
@caugner
Copy link
Contributor

caugner commented Nov 15, 2022

💡 Just realized: Edge 79 followed after Edge 12!

@caugner caugner added the accepting PR We invite you to open a PR to resolve this issue. label Nov 15, 2022
@caugner
Copy link
Contributor

caugner commented Nov 15, 2022

@danielhjacobs Would you be interested in looking into this?

Essentially, when support was removed in version N (e.g. Edge 79), we should show version N-1 (e.g. Edge 12) in the version range instead.

@caugner caugner changed the title Browser Compatibility tables are unclear when support for an item has been removed BCD tables include the version_removed in the version range Nov 15, 2022
@caugner caugner changed the title BCD tables include the version_removed in the version range BCD tables include the version_removed in the version range Nov 15, 2022
@danielhjacobs
Copy link
Contributor

Opened #7589

@foolip
Copy link
Contributor Author

foolip commented Nov 15, 2022

💡 Just realized: Edge 79 followed after Edge 12!

Almost. Edge 18 was followed by Edge 79.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PR We invite you to open a PR to resolve this issue. browser-compat issues related to the browser compatibility data tables (BCD) p3 We don't have visibility when this will be addressed. ux make the user experience awesome
Projects
None yet
6 participants