Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci/pr-check_redirects): remove path filter to always run the required test #16903

Merged
merged 2 commits into from
Nov 17, 2023
Merged

chore(ci/pr-check_redirects): remove path filter to always run the required test #16903

merged 2 commits into from
Nov 17, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Nov 10, 2023 •
edited
Loading

Description

The pr-check_redirects workflow is now a required ci test. It should always be triggerd, removing the path filter as the upstream does.

Related issues and pull requests

mdn/content#28277
mdn/content#30210

@yin1999 yin1999 requested a review from a team as a code owner November 10, 2023 13:21
@github-actions github-actions bot added the system Infrastructure and configuration for the project label Nov 10, 2023
@yin1999
Copy link
Member Author

yin1999 commented Nov 14, 2023 •
edited
Loading

Hey @bsmth. Would mind to look at this? This blocks my contribution to translation-guides (#16913), as the workflow is now a required test before merging PRs.

bsmth
bsmth approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yin1999 - okay to merge this now?

@yin1999
Copy link
Member Author

yin1999 commented Nov 17, 2023

Thanks @yin1999 - okay to merge this now?

Yes. I'll merge this. Thanks for your review @bsmth ❤️

@yin1999 yin1999 merged commit 53dbdb2 into main Nov 17, 2023
7 of 8 checks passed
@yin1999 yin1999 deleted the yin1999-patch-1 branch November 17, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
system Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yin1999 @bsmth