Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci/pr-check_redirects): remove path filter to always run the required test #16903

Merged
merged 2 commits into from
Nov 17, 2023
Merged

chore(ci/pr-check_redirects): remove path filter to always run the required test #16903

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e73956
chore(ci/pr-check_redirects): remove path filter to always run the re…
yin1999 Nov 10, 2023
83f894d
add path filter
yin1999 Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions .github/workflows/pr-check_redirects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ on:
pull_request:
branches:
- main
paths:
- .nvmrc
- files/**
- .github/workflows/pr-check_redirects.yml

jobs:
check_redirects:
Expand All @@ -18,19 +14,35 @@ jobs:
steps:
- uses: actions/checkout@v4

# This is a "required" workflow so path filtering can not be used:
# https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
# We have to rely on a custom filtering mechanism to run the checks only if required files are modified.
- uses: dorny/paths-filter@v2
name: See if any file needs checking
id: filter
with:
filters: |
required_files:
- ".nvmrc"
- "files/**"
- ".github/workflows/pr-check_redirects.yml"

- uses: actions/checkout@v4
if: steps.filter.outputs.required_files == 'true'
with:
repository: mdn/content
path: mdn/content

- name: Setup Node.js environment
if: steps.filter.outputs.required_files == 'true'
uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"
cache: "yarn"
cache-dependency-path: mdn/content/yarn.lock

- name: Install all yarn packages
if: steps.filter.outputs.required_files == 'true'
working-directory: ${{ github.workspace }}/mdn/content
run: |
yarn --frozen-lockfile
Expand All @@ -39,6 +51,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Check redirects file(s)
if: steps.filter.outputs.required_files == 'true'
env:
CONTENT_ROOT: ${{ github.workspace }}/mdn/content/files
CONTENT_TRANSLATED_ROOT: ${{ github.workspace }}/files
Expand Down
Loading