CI: Avoid path filtering in "required" workflows

[OnkarRuikar]

The workflow checks only files/en-us/_redirects.txt file. It doesn't work on any other file.

It is not required to run this workflow in every PR. This PR reduces the workflows scope to only the _redirects.txt file and the workflow file.

Also, there is no point in making this workflow "required" in settings.

Edit: Had to revert the original changes due to the edge case. Now the PR focuses only on avoiding path filtering.

/cc @bsmth

[bsmth]

Thanks, @OnkarRuikar - good cleanup, leaving a +1 👍🏻

there is no point in making this workflow "required" in settings.

Why not? It seems like one of the more useful jobs to have PRs block if the author made a tooling mistake that we don't want to land on main:

https://github.com/mdn/content/actions/runs/5387620912/job/14582323137

[OnkarRuikar]

there is no point in making this workflow "required" in settings.

Why not? It seems like one of the more useful jobs to have PRs block if the author made a tooling mistake that we don't want to land on main:

True! We do need these as required. Another (following) issue was lingering in my mind that is why the statement.

I was also thinking of the issue of these "required" workflows not running on other files and disabling the merge button. In other words we don't want to run redirects-check command for all the PRs but we do want to run the workflow as it is "required". GitHub docs suggests not to use path filter for "required" workflows.

Warning: If a workflow is skipped due to path filtering, branch filtering or a commit message, then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging.

For this reason you should not use path or branch filtering to skip workflow runs if the workflow is required. For more information, see "Skipping workflow runs" and "Required workflows."

If, however, a job within a workflow is skipped due to a conditional, it will report its status as "Success". For more information, see "Using conditions to control job execution."

So updating these workflows using dorny/paths-filter action as requested by @Josh-Cena.

[yin1999]

Hi Onkar, in translated-content, we have occured the following case:

There is a redirection from some-old-slug to new-slug, but the contributor just created a document and the slug is some-old-slug, when we merge this PR, the redirection rule is broken. But in this case, we have merge one PR that have moved documents (by sync-translated-content). I'm not sure is there any edge case may break the redirection rule.

[OnkarRuikar]

but the contributor just created a document and the slug is some-old-slug,

This is a very rare case but it is possible so putting the old "files/**" back.

So the the PRs scope has now reduced to only avoiding path filtering for "required" workflows. I've changed the PR title and updated the code to do just that.

[bsmth]

Thanks @OnkarRuikar - I think we're good to go