Move WebAssembly reference to the WASM section #20603
Conversation
Josh-Cena
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:JS
This comment was marked as resolved.
This comment was marked as resolved.
| /en-US/docs/WebAssembly/API/Table/grow /en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Table/grow | ||
| /en-US/docs/WebAssembly/API/Table/length /en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Table/length | ||
| /en-US/docs/WebAssembly/API/Table/set /en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Table/set | ||
| /en-US/docs/WebAssembly/API/Instance /en-US/docs/WebAssembly/JavaScript_interface/Instance |
There was a problem hiding this comment.
Interesting—I didn't know once upon a time these docs were indeed under WebAssembly. I wonder what motivated the change.
There was a problem hiding this comment.
@Josh-Cena I suspect because these are JavaScript interfaces - WASM might have different APIs in other runtimes. Technically these are probably WebAPIs.
They probably belong in Web APIs, but I think you've done the right thing - WASM is where they are likely to be discovered, and we have a pretty hard rule that the JavaScript section is for language features. I added a note in https://github.com/orgs/mdn/discussions/151#discussioncomment-3630607 to say this.
There was a problem hiding this comment.
Thanks for jumping on this.
All the pages have the sidebar macro {{JSRef}} but these will not longer be part of the JSRef tree. So we need to sort these out in the WASM context.
I have not looked at whether there are any jsxrefs mentioning these entities in the source, but we should try fix them if they are.
|
Erf, there are a lot of jsxrefs to WebAssembly. I'll try fixing them. |
|
I've done some crappy regex search & replace and I think I've got all of them. |
|
Looks good to me. Can you update the groupdata to include Exception and Tag in the sidebar (I missed those when I created them)? |
|
Is the WASM sidebar using the GroupData? Looks like it's hardcoded in the macro. Looking at https://github.com/mdn/yari/blob/main/kumascript/macros/WebAssemblySidebar.ejs, we need to stop that one from using |
Looks like it isn't. Which is a pity in some ways. Otherwise I think this is good. Would be helpful to have sanity check from @MendyBerger or @sideshowbarker too. @sideshowbarker can you review the yari change? |
|
@MendyBerger or @sideshowbarker - no comment? I assume you're OK with this and will merge it on Monday if there is no feedback @Josh-Cena If you can fix the conflicts by Monday I will merge this because I think it is better. |
Josh-Cena
force-pushed
the
mv-webassembly
branch
from
16a6d42
to
1da2139
Compare
|
@hamishwillee think this is just moving content around, so I don't really have much to say here. |
|
Thanks @MendyBerger. That's OK. I'm sure if you thought that this made no sense in terms of a location you'd speak up (i.e. you thought no one would find it). |
|
Merging. Thanks @Josh-Cena . There might be late feedback from others, but IMO this is clearly better than the current situation., |
* Move WebAssembly reference to the WASM section * Use WASM sidebar * Remove jsxref
Description
See mdn/mdn-community#151
Motivation
Additional details
Related issues and pull requests