Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WebAssembly API out of JavaScript builtins #20609

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Move WebAssembly API out of JavaScript builtins #20609

merged 1 commit into from
Nov 14, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR moves the WebAssembly API data out of the JavaScript builtins folder and into the WebAssembly folder. This is an attempt to fix #20349.

@github-actions github-actions bot added data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript data:wasm 🦾 Compat data for Web Assembly features. https://developer.mozilla.org/en-US/docs/WebAssembly labels Aug 27, 2023
@queengooborg queengooborg added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Aug 27, 2023
@github-actions github-actions bot added the linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. label Aug 27, 2023
queengooborg added a commit to openwebdocs/mdn-bcd-collector that referenced this pull request Aug 27, 2023
Sister PR to mdn/browser-compat-data#20609.  Merge when that PR is merged.
@github-actions github-actions bot removed the linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. label Aug 27, 2023
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Sep 18, 2023
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@Elchi3
Copy link
Member

Elchi3 commented Nov 13, 2023

This does need a PR on the content side to basically update the BCD queries in MDN page front-matters, right?
The move on MDN has already happened in mdn/content#20603

@Elchi3
Copy link
Member

Elchi3 commented Nov 14, 2023

I've opened mdn/content#30259

@Elchi3 Elchi3 removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Nov 14, 2023
Fix linter to allow Deno/NodeJS in WASM category
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 14, 2023
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @queengooborg 👍

@Elchi3 Elchi3 merged commit a9da6c1 into main Nov 14, 2023
7 checks passed
@Elchi3 Elchi3 deleted the wasm/api branch November 14, 2023 09:54
queengooborg added a commit to openwebdocs/mdn-bcd-collector that referenced this pull request Nov 15, 2023
* Move WebAssembly API to `webassembly.api`

Sister PR to mdn/browser-compat-data#20609.  Merge when that PR is merged.

* Fix unittest
dontcallmedom added a commit to dontcallmedom/mdn-gaps that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript data:wasm 🦾 Compat data for Web Assembly features. https://developer.mozilla.org/en-US/docs/WebAssembly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are we documenting the WebAssembly JS API in the right place?
2 participants