Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/WASMSidebar): remove use of jsxref #7132

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Conversation

Josh-Cena
Copy link
Member

Summary

Accompanying change of mdn/content#20603

Problem

Solution


Screenshots

Before

After


How did you test this change?

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Sep 13, 2022
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to wait for mdn/content#20603 to land.

@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Sep 15, 2022
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Sep 15, 2022
@Josh-Cena
Copy link
Member Author

Ready for merge

@Josh-Cena
Copy link
Member Author

Pinging @caugner

@caugner caugner merged commit 7688b07 into mdn:main Sep 22, 2022
@Josh-Cena Josh-Cena deleted the mv-wasm branch September 22, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants