Remove `api/`s that has never been supported #10581

saschanaz · 2021-05-22T20:47:55Z

Summary

Splitted from #6854 and covers changes only in api/. @foolip

Test results and supporting details

Related issues

#6809

saschanaz · 2021-05-22T20:49:21Z

Hmm, probably better to split further? (#10582, probably not worth to split more)

saschanaz · 2021-05-22T20:58:12Z

api/PaymentAddress.json

-            },
-            "firefox_android": {
-              "version_added": false,
-              "notes": "Available only in nightly builds."


There are several notes here like this, but I guess we can remove them since the interface itself is deprecated and thus we don't expected them to be shipped.

@Elchi3 do you have a link to the recent issue about representing preview browsers? I can't find it...

But in any case I agree with removing this one.

Removing sounds good to me, too.
The proposal on "preview" is here: #10334 (and I think it would address this use case)

foolip · 2021-05-23T09:17:06Z

I'll review this as-is and if there are tricky bits those could be split further.

foolip

Thanks! Some of this could be merged now, and some needs to be paired with content updates. If you want to break this PR into smaller bits, I'd be happy to rubberstamp the result if it's just a subset of this.

foolip · 2021-05-24T07:15:10Z

api/BluetoothRemoteGATTService.json

-          }
-        }
-      },
-      "isPrimary": {


This is also being updated in #10197.

foolip · 2021-05-24T07:47:25Z

api/BluetoothRemoteGATTService.json

@@ -272,104 +272,6 @@
          }
        }
      },
-      "getCharacteristics": {


https://mdn-bcd-collector.appspot.com/tests/api/BluetoothRemoteGATTService/getCharacteristics shows support in Chrome, and this data is being updated in #10197.

foolip · 2021-05-24T08:18:57Z

api/ConstrainULong.json

@@ -1,53 +0,0 @@
-{
-  "api": {
-    "ConstrainULong": {


This is covered by #9930. The reason this is all-false is probably that Chromium, Gecko and WebKit all have ConstrainLong in its source for MediaTrackConstraintSet and not ConstrainULong.

I guess a spec issue to use ConstrainLong in the spec as well would be best here.

foolip · 2021-05-24T10:16:03Z

api/Document.json

@@ -11217,54 +11217,6 @@
          }
        }
      },
-      "undoManager": {


This removal is correct, it's from https://github.com/WebKit/WebKit/blob/92ce6b62a589a0a70da09a6adfcfa03a07624467/Source/WebCore/dom/Document%2BUndoMananger.idl#L27 but hasn't been shipped.

foolip · 2021-05-24T10:16:29Z

api/Document.json

@@ -11217,54 +11217,6 @@
          }
        }
      },
-      "undoManager": {
-        "__compat": {
-          "mdn_url": "https://developer.mozilla.org/docs/Web/API/Document/undoManager",


404, nothing to clean up here 👍

foolip · 2021-05-24T10:35:12Z

api/ULongRange.json

@@ -1,53 +0,0 @@
-{
-  "api": {
-    "ULongRange": {


This is like ConstrainULong, a long vs. unsigned long difference in spec and implementations. I'd break these two out into a separate PR.

foolip · 2021-05-24T10:37:00Z

api/XRPermissionDescriptor.json

@@ -1,200 +0,0 @@
-{
-  "api": {
-    "XRPermissionDescriptor": {


This is a dictionary, which I don't think we should have in BCD but sometimes do. But whatever the rule on that, there's no trace of XRPermissionDescriptor in Chromium, Gecko or WebKit so this removal is fine.

This is a dictionary, which I don't think we should have in BCD but sometimes do.

Is there a guideline for the "sometimes do" part?

My opinion is that they should never be in BCD, like mixins, but there's no guideline AFAIK. @ddbeck and @Elchi3 might have opinions too.

Splitting out this and the following XR thing would unblock this PR I think.

foolip · 2021-05-24T10:38:41Z

api/XRPermissionStatus.json

@@ -1,102 +0,0 @@
-{
-  "api": {
-    "XRPermissionStatus": {


I can't find this interface in Chromium, Gecko or WebKit except in tests/comments, so OK to remove.

foolip · 2021-05-24T10:38:54Z

api/XRPermissionStatus.json

-  "api": {
-    "XRPermissionStatus": {
-      "__compat": {
-        "mdn_url": "https://developer.mozilla.org/docs/Web/API/XRPermissionStatus",


https://developer.mozilla.org/docs/Web/API/XRPermissionStatus will need to be removed.

It still exists in the spec and there is a tracking issue https://bugzilla.mozilla.org/show_bug.cgi?id=1582344, so maybe it should remain? 🤔

Is it shipped anywhere yet?

Nah, but there have been requests to keep things that authors want to eventually ship, #6954 (comment) for example. #10619 is relevant here I guess.

foolip · 2021-05-24T10:39:19Z

api/XRPermissionDescriptor.json

-  "api": {
-    "XRPermissionDescriptor": {
-      "__compat": {
-        "mdn_url": "https://developer.mozilla.org/docs/Web/API/XRPermissionDescriptor",


https://developer.mozilla.org/docs/Web/API/XRPermissionDescriptor will need to be removed.

Split from mdn#10581.

foolip · 2021-05-24T22:10:42Z

@saschanaz will you also send a PR to remove the same bits on MDN, or would you like someone else to take care of it?

Element.tabStop is redirected to ShadowRoot.delegatesFocus per the description in the removed page. HTMLElement.forceSpellCheck is redirected to the spellcheck attributes, as the closest / most relevant thing on the platform. The regionCode entries are redirected to their parent interfaces. BCD cleanup: mdn/browser-compat-data#10581

foolip · 2021-05-28T15:28:28Z

I've sent mdn/content#5434 to go with this PR.

Element.tabStop is redirected to ShadowRoot.delegatesFocus per the description in the removed page. HTMLElement.forceSpellCheck is redirected to the spellcheck attributes, as the closest / most relevant thing on the platform. The regionCode entries are redirected to their parent interfaces. BCD cleanup: mdn/browser-compat-data#10581

* Bump version to v3.3.6 * Add release note for #10646 * Add release note for #10581 * Add release note for #10685 * Add release note for #10691 * Add release note for #6957 * Add release note for #10721 * Add release note for #10695 * Add release note for #9821 * Add release note for #10681 * Add release note for #10725 * Add stats * Add release date * Wordsmith

Split from #10581.

Remove api/s that has never been supported

dd827c6

github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 22, 2021

saschanaz added 2 commits May 22, 2021 22:53

Merge remote-tracking branch 'upstream/main' into remove-nosupport-api

9a2b475

Split webrtc to mdn#10582

6f1ac59

saschanaz commented May 22, 2021

View reviewed changes

foolip added the needs-release-note 📰 label May 22, 2021

foolip reviewed May 24, 2021

View reviewed changes

saschanaz mentioned this pull request May 24, 2021

Update BluetoothRemoteGATTService members where no support data exists #10620

Closed

saschanaz added 3 commits May 24, 2021 22:06

Merge remote-tracking branch 'upstream/main' into remove-nosupport-api

552d934

Split GATT member updates to mdn#10620

c0c36a6

Split paymentrequest as mdn#10622

2852514

saschanaz added a commit to saschanaz/browser-compat-data that referenced this pull request May 24, 2021

Remove ULongRange and ConstrainULong

e046b67

Split from mdn#10581.

saschanaz mentioned this pull request May 24, 2021

Remove ULongRange and ConstrainULong #10623

Merged

Split *ULong* removal as mdn#10623

952b1e6

foolip mentioned this pull request May 28, 2021

Remove APIs that have never been shipped mdn/content#5434

Merged

Merge branch 'main' into remove-nosupport-api

579d3ad

saschanaz mentioned this pull request May 30, 2021

Add notes to XRPermissionStatus, remove XRPermissionDescriptor #10672

Merged

Split XRPermission* to mdn#10672

bbae3fb

foolip approved these changes May 30, 2021

View reviewed changes

foolip merged commit b79d65e into mdn:main May 30, 2021

saschanaz deleted the remove-nosupport-api branch May 30, 2021 11:44

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jun 2, 2021

Add release note for mdn#10581

05fec81

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jun 3, 2021

Add release note for mdn#10581

2e6072d

ddbeck mentioned this pull request Jun 4, 2021

Remove notes about nightly build from PaymentAddress #10621

Merged

queengooborg pushed a commit that referenced this pull request Jul 27, 2021

Remove ULongRange and ConstrainULong (#10623)

27ebc31

Split from #10581.

queengooborg removed the needs-release-note 📰 label Apr 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `api/`s that has never been supported #10581

Remove `api/`s that has never been supported #10581

saschanaz commented May 22, 2021

saschanaz commented May 22, 2021 •

edited

Loading

saschanaz May 22, 2021

foolip May 24, 2021

Elchi3 May 24, 2021

foolip commented May 23, 2021

foolip left a comment

foolip May 24, 2021

foolip May 24, 2021

foolip May 24, 2021

foolip May 24, 2021

foolip May 24, 2021

foolip May 24, 2021

foolip May 24, 2021

saschanaz May 24, 2021

foolip May 27, 2021

foolip May 28, 2021

foolip May 24, 2021

foolip May 24, 2021

saschanaz May 27, 2021

foolip May 27, 2021

saschanaz May 27, 2021

foolip May 24, 2021

foolip commented May 24, 2021

foolip commented May 28, 2021

Remove api/s that has never been supported #10581

Remove api/s that has never been supported #10581

Conversation

saschanaz commented May 22, 2021

Summary

Test results and supporting details

Related issues

saschanaz commented May 22, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

foolip commented May 23, 2021

foolip left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

foolip commented May 24, 2021

foolip commented May 28, 2021

Remove `api/`s that has never been supported #10581

Remove `api/`s that has never been supported #10581

saschanaz commented May 22, 2021 •

edited

Loading