Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data for paymentmethodchange event #10622

Merged
merged 1 commit into from
May 31, 2021

Conversation

saschanaz
Copy link
Contributor

Copied from onpaymentmethodchange.

I think there should be a linter for this 🤔

Summary

A simple data copy.

Test results and supporting details

Related issues

Copied from onpaymentmethodchange.

I think there should be a linter for this 🤔
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 24, 2021
saschanaz added a commit to saschanaz/browser-compat-data that referenced this pull request May 24, 2021
@foolip
Copy link
Collaborator

foolip commented May 31, 2021

I think there should be a linter for this 🤔

Yeah, there's a lot of obviously wrong data that could be caught be something pretty simple here. The trouble is there's no hard rule, neither kind of entry implies the other. See #7545.

Some kind of grouping concept would be useful I think, where the expectation is that data should match but there's a way to make it not match if that's really what happened.

Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running mdn-bcd-collector doesn't update the onpaymentmethodchange entry this is based on, so it's probably mostly right.

@foolip foolip merged commit 063fa82 into mdn:main May 31, 2021
@mdn mdn deleted a comment from Edimalius Jun 1, 2021
@mdn mdn deleted a comment from Edimalius Jun 1, 2021
@saschanaz saschanaz deleted the paymentmethodchange branch June 1, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants