Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api/s that has never been supported #10581

Merged
merged 9 commits into from
May 30, 2021
Merged

Remove api/s that has never been supported #10581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dd827c6
Remove `api/`s that has never been supported
saschanaz May 22, 2021
9a2b475
Merge remote-tracking branch 'upstream/main' into remove-nosupport-api
saschanaz May 22, 2021
6f1ac59
Split webrtc to #10582
saschanaz May 22, 2021
552d934
Merge remote-tracking branch 'upstream/main' into remove-nosupport-api
saschanaz May 24, 2021
c0c36a6
Split GATT member updates to #10620
saschanaz May 24, 2021
2852514
Split paymentrequest as #10622
saschanaz May 24, 2021
952b1e6
Split *ULong* removal as #10623
saschanaz May 24, 2021
579d3ad
Merge branch 'main' into remove-nosupport-api
saschanaz May 30, 2021
bbae3fb
Split XRPermission* to #10672
saschanaz May 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 0 additions & 48 deletions api/Document.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11223,54 +11223,6 @@
}
}
},
"undoManager": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal is correct, it's from https://github.com/WebKit/WebKit/blob/92ce6b62a589a0a70da09a6adfcfa03a07624467/Source/WebCore/dom/Document%2BUndoMananger.idl#L27 but hasn't been shipped.

"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Document/undoManager",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404, nothing to clean up here 👍

"support": {
"chrome": {
"version_added": false
},
"chrome_android": {
"version_added": false
},
"edge": {
"version_added": false
},
"firefox": {
"version_added": false
},
"firefox_android": {
"version_added": false
},
"ie": {
"version_added": false
},
"opera": {
"version_added": false
},
"opera_android": {
"version_added": false
},
"safari": {
"version_added": false
},
"safari_ios": {
"version_added": false
},
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
}
}
},
"visibilitychange_event": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Document/visibilitychange_event",
Expand Down
48 changes: 0 additions & 48 deletions api/Element.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8234,54 +8234,6 @@
}
}
},
"tabStop": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can find no trace of this in Chromium, Gecko or WebKit so this removal seems correct.

"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Element/tabStop",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.mozilla.org/en-US/docs/Web/API/Element/tabStop will need to be removed too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm creating a PR to remove this.

"support": {
"chrome": {
"version_added": false
},
"chrome_android": {
"version_added": false
},
"edge": {
"version_added": false
},
"firefox": {
"version_added": false
},
"firefox_android": {
"version_added": false
},
"ie": {
"version_added": false
},
"opera": {
"version_added": false
},
"opera_android": {
"version_added": false
},
"safari": {
"version_added": false
},
"safari_ios": {
"version_added": false
},
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
"standard_track": false,
"deprecated": true
}
}
},
"tagName": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Element/tagName",
Expand Down
48 changes: 0 additions & 48 deletions api/HTMLElement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,54 +1079,6 @@
}
}
},
"forceSpellCheck": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No trace of this in Chromium, Gecko or WebKit. In WebKit it appears in some performance tests, seemingly copied from the HTML spec where this once appeared:
whatwg/html@4a0651c
whatwg/html@c79ad81

"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLElement/forceSpellCheck",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/forceSpellCheck will need to be removed.

"support": {
"chrome": {
"version_added": false
},
"chrome_android": {
"version_added": false
},
"edge": {
"version_added": false
},
"firefox": {
"version_added": false
},
"firefox_android": {
"version_added": false
},
"ie": {
"version_added": false
},
"opera": {
"version_added": false
},
"opera_android": {
"version_added": false
},
"safari": {
"version_added": false
},
"safari_ios": {
"version_added": false
},
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
"standard_track": false,
"deprecated": false
}
}
},
"gotpointercapture_event": {
"__compat": {
"description": "<code>gotpointercapture</code> event",
Expand Down
50 changes: 0 additions & 50 deletions api/PaymentAddress.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,56 +551,6 @@
}
}
},
"regionCode": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PaymentAddress/regionCode",
"support": {
"chrome": {
"version_added": false
},
"chrome_android": {
"version_added": false
},
"edge": {
"version_added": false
},
"firefox": {
"version_added": false,
"notes": "Available only in nightly builds."
},
"firefox_android": {
"version_added": false,
"notes": "Available only in nightly builds."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several notes here like this, but I guess we can remove them since the interface itself is deprecated and thus we don't expected them to be shipped.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Elchi3 do you have a link to the recent issue about representing preview browsers? I can't find it...

But in any case I agree with removing this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing sounds good to me, too.
The proposal on "preview" is here: #10334 (and I think it would address this use case)

},
"ie": {
"version_added": false
},
"opera": {
"version_added": false
},
"opera_android": {
"version_added": false
},
"safari": {
"version_added": false
},
"safari_ios": {
"version_added": false
},
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
"standard_track": false,
"deprecated": true
}
}
},
"sortingCode": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PaymentAddress/sortingCode",
Expand Down