Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share docker in BEIT #9

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Share docker in BEIT #9

wants to merge 44 commits into from

Conversation

mchades
Copy link
Owner

@mchades mchades commented Aug 9, 2024

What changes were proposed in this pull request?

(Please outline the changes and how this PR fixes the issue.)

Why are the changes needed?

(Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.)

Fix: # (issue)

Does this PR introduce any user-facing change?

(Please list the user-facing changes introduced by your change, including

  1. Change in user-facing APIs.
  2. Addition or removal of property keys.)

How was this patch tested?

(Please test your changes, and provide instructions on how to test it:

  1. If you add a feature or fix a bug, add a test to cover your changes.
  2. If you fix a flaky test, repeat it for many times to prove it works.)

@mchades mchades force-pushed the share-docker branch 2 times, most recently from 47e529b to 5431be2 Compare August 9, 2024 09:13
@mchades mchades closed this Aug 9, 2024
@mchades mchades reopened this Aug 9, 2024
@mchades mchades force-pushed the share-docker branch 2 times, most recently from 7cd649d to 3c4dd6f Compare August 9, 2024 09:24
@mchades mchades added the bug Something isn't working label Aug 9, 2024
@mchades mchades closed this Aug 9, 2024
@mchades mchades reopened this Aug 9, 2024
@mchades mchades added debug and removed bug Something isn't working labels Aug 9, 2024
@mchades mchades closed this Aug 12, 2024
@mchades mchades reopened this Aug 12, 2024
@mchades mchades closed this Aug 12, 2024
@mchades mchades reopened this Aug 12, 2024
@mchades mchades force-pushed the share-docker branch 12 times, most recently from e7a1642 to acb86f3 Compare August 19, 2024 04:18
@yuqi1129 @jerryshao
[apache#4520] Imporvement(jdbc-catalogs): Shrink JDBC catalog binary …
0af3353 
…package size to about 3MB. (apache#4521)

### What changes were proposed in this pull request?

Remove some unnecessary jar dependencies in the runtime classpath for
JDBC catalogs.

### Why are the changes needed?

Shrink JDBC catalog package.

Fix: apache#4520 

### Does this PR introduce _any_ user-facing change?

N/A.
### How was this patch tested?

Test locally and CI.

MySQL catalog:

![image](https://github.com/user-attachments/assets/ddd24475-e7c7-4900-9ec8-6b2dba25882e)

PostgreSQL catalog:

<img width="1315" alt="image"
src="https://github.com/user-attachments/assets/548121c6-a940-455a-83dc-e14f3f7788ee">
Doris catalog:


![image](https://github.com/user-attachments/assets/c952f112-c4f1-404e-8709-56be8b8e7214)

---------

Co-authored-by: Jerry Shao <[email protected]>
jerqi and others added 14 commits August 29, 2024 16:23
@jerqi
[apache#4767] fix(docs): Update the document of playground (apache#4768)
19a8ccc 
### What changes were proposed in this pull request?

Update the document of playground

### Why are the changes needed?

Fix: apache#4767
Just update the document according to the latest playground document.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Just documents.
@mchades
[apache#4782] fix(doc): correct partiton doc (apache#4784)
4295ee5 
### What changes were proposed in this pull request?

correct partiton doc

### Why are the changes needed?

Fix: apache#4782 

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?

no need
@yuqi1129
[Minor] improvement(docs): Fix docs problem about configuration defau…
002eb4c 
…lt value (apache#4773)

### What changes were proposed in this pull request?

Change default value from `` to ''(empty string)

### Why are the changes needed?

for better user experience.


### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
@LauraXia123
[apache#4685] fix docs img inline style issue for md (apache#4761)
e0b98a2 
### What changes were proposed in this pull request?
Removed the style tag for the md can not support jsx, and the border
style is still work.
<img width="1745" alt="image"
src="https://github.com/user-attachments/assets/020fb1ce-97ff-4330-9a09-a0bd71f87cd2">


### Why are the changes needed?
md can not support jsx, make the raw HTML is displaying on the GitHub
pages
Fix: apache#4685

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
N/A
@FANNG1
[MINOR] Fix Spark and Flink download link (apache#4781)
7e1f874 
### What changes were proposed in this pull request?
Fix Spark and Flink download link

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
document
@LauraXia123
[apache#4737] improvement(ui): update documentation link (apache#4771)
8906c03 
### What changes were proposed in this pull request?
link the apache website instead of a company websit

### Why are the changes needed?
The latest docs will release at apache website

Fix: apache#4737

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
N/A
@jerqi
[apache#4754] fix(docs): Optimize the document of access control (apa…
5295dd9 
…che#4776)

### What changes were proposed in this pull request?

Optimize the document of access control

### Why are the changes needed?

Fix: apache#4754

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?
Just docs.
@jerryshao
[apache#4764] fix(docs): Fix several typos in docs (apache#4794)
ff18081 
### What changes were proposed in this pull request?

This PR fixes several typos in docs.

### Why are the changes needed?

To make the docs correct.

Fix: apache#4764 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

N/A
@yuqi1129
[apache#4785] improvement(docs): Remove the copy right datastrato i…
f4143ab 
…n the picture. (apache#4800)

### What changes were proposed in this pull request?

Remove any improper copyright data after the project has been donated to
Apache

### Why are the changes needed?

Better user experience.

Fix: apache#4785 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
@mchades
[apache#4528] improvement(hive-catalog): reduce hive catalog libs siz…
c01edab 
…e from 146MB to 43MB (apache#4531)

### What changes were proposed in this pull request?

remove some unnecessary dependencies

### Why are the changes needed?

Fix: apache#4528 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

CI passed
@justinmclean
[Minor] fix footer (apache#4802)
9bcfc9e 
### What changes were proposed in this pull request?

Fix copyright and footer name.

### Why are the changes needed?

As the ASF is the collective copyright owner.

Fix: # N/A

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Compiled locally.
@LauraXia123
[apache#4805] format license headers for open api yaml files (apache#…
397b338 
…4807)

### What changes were proposed in this pull request?
format license headers for open api yaml files

### Why are the changes needed?
ci check failed on gravitino-site

Fix: apache#4805

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
N/A
@coolderli @FANNG1
[apache#3514] improvement(flink-connector): add flink-connector-runti…
6e4e103 
…me to build flink connector (apache#4791)

### What changes were proposed in this pull request?

- add flink runtime connector

### Why are the changes needed?

Fix: apache#3514 

### Does this PR introduce _any_ user-facing change?

- no

### How was this patch tested?

- local test

---------

Co-authored-by: fanng <[email protected]>
@yuqi1129
[Minor] fix(docs): Fix docs mistake for partitioned table created by …
972edc1 
…Trino (apache#4813)

### What changes were proposed in this pull request?

Fix the error in the example SQL.

### Why are the changes needed?

For a better user experience. 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A.
@mchades mchades force-pushed the share-docker branch 4 times, most recently from a917499 to 3cf9477 Compare August 30, 2024 11:49
@caican00
[apache#4814] Improvement (catalog-lakehouse-paimon): use purgeTable …
ec93308 
…for Paimon instead of dropTable inGravitino (apache#4806)

### What changes were proposed in this pull request?

the dropTable in Paimon will both delete the metadata and data and skip
the trash, as discussed in
apache#1436 , Gravitino Paimon
catalog should use purgeTable not dropTable

### Why are the changes needed?
apache#4814

### Does this PR introduce any user-facing change?
yes, updated the doc.

### How was this patch tested?
existing ITs and UTs.
jerqi and others added 5 commits August 30, 2024 22:10
@jerqi
[apache#4812] fix(core): Make ensure the schema exists before creatin…
a6a69cc 
…g tables and topics (apache#4818)

### What changes were proposed in this pull request?
If the schema is not created by Gravitino, the Gravitino will lack the
metadata in the backend storage.
If we create a table in this schema, the storage won't contain the
metadata. So it will fail to set owner. Because the storage won't store
the table. Because the storage won't contain schema id.

This won't bring too much performance cost. Because loadSchema will use
read lock after first loading. If we have cache, we could be more quick.

### Why are the changes needed?

Fix: apache#4812 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Added a ut.
@mchades
[MINOR] fix(CI): exclude flinkIT from backendIT (apache#4822)
363af78 
### What changes were proposed in this pull request?

exclude flinkIT from backendIT

### Why are the changes needed?

backendIT does not need flinkIT

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

visit CI log
@noidname01
[apache#4803] improvement(client-python): Delete egg-info directory d…
252b4c4 
…ue to Python package renamed improvement (apache#4821)

### What changes were proposed in this pull request?

* Modify `clean` task to delete `apache_gravitino.egg_info`

### Why are the changes needed?

Fix: apache#4803 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

./gradlew client:client-python:clean

Co-authored-by: TimWang <[email protected]>
@mchades
remove integration-test module
becb0d9
@mchades
minimize changes
07cc7a6
@mchades mchades force-pushed the share-docker branch 3 times, most recently from 9aa81a9 to 4be1fe3 Compare September 1, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
debug action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.