[#4520] Imporvement(jdbc-catalogs): Shrink JDBC catalog binary package size to about 3MB. #4521
Conversation
yuqi1129
changed the title
yuqi1129
changed the title
| exclude("guava-*.jar") | ||
| exclude("log4j-*.jar") | ||
| exclude("slf4j-*.jar") | ||
| } |
There was a problem hiding this comment.
Why do we need to remove these jars explicitly? If we're using them only in compile, maybe we can change from "implementation" to "compileOnly"?
There was a problem hiding this comment.
Those jars already exist in the server class path, duplicated jars are useless.
There was a problem hiding this comment.
If we're using them only in compile, maybe we can change from "implementation" to "compileOnly"?
Yeah, let me have a try.
There was a problem hiding this comment.
If we're using them only in compile, maybe we can change from "implementation" to "compileOnly"?
Yeah, let me have a try.
It seems that making it compileOnly can't pass tests and runs into classes not found problem.
| } | ||
| implementation(project(":catalogs:catalog-common")) { | ||
| exclude(group = "*") | ||
| } |
There was a problem hiding this comment.
Why only mysql relies on "catalog-common"?
There was a problem hiding this comment.
It was added by @FANNG1 , let me check the reason.
There was a problem hiding this comment.
Only MySQL use MysqlConstants.GRAVITINO_AUTO_INCREMENT_OFFSET_KEY and supports the feature auto_increment now.
What changes were proposed in this pull request?
Remove some unnecessary jar dependencies in the runtime classpath for JDBC catalogs.
Why are the changes needed?
Shrink JDBC catalog package.
Fix: #4520
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
Test locally and CI.
MySQL catalog:
PostgreSQL catalog: