Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catalog tests #6

Closed
wants to merge 4 commits into from
Closed

catalog tests #6

wants to merge 4 commits into from

Conversation

mchades
Copy link
Owner

@mchades mchades commented Jun 6, 2024

What changes were proposed in this pull request?

(Please outline the changes and how this PR fixes the issue.)

Why are the changes needed?

(Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.)

Fix: # (issue)

Does this PR introduce any user-facing change?

(Please list the user-facing changes introduced by your change, including

  1. Change in user-facing APIs.
  2. Addition or removal of property keys.)

How was this patch tested?

(Please test your changes, and provide instructions on how to test it:

  1. If you add a feature or fix a bug, add a test to cover your changes.
  2. If you fix a flaky test, repeat it for many times to prove it works.)

mygrsun and others added 4 commits June 5, 2024 22:21
@mygrsun @mygrsun2
[apache#3403] fix(hive-catalog): add hive catalog property list-all-t…
1952737 
…ables (apache#3703)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

Add a Hive catalog property "list-all-tables". Using this property to
control whether the Iceberg table is displayed in the Hive table list.

### Why are the changes needed?

The bug is a schema has the Iceberg tables in the Hive catalog

Fix: apache#3403

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

1.create a hive catalog with "list-all-tables " property.
2.crate a database and a iceberg table  in the catalog by hive beeline
3.check whether the table is displayed in the catalog .

---------

Co-authored-by: ericqin <[email protected]>
@shaofengshi
[apache#3702]refactor(API): Refactoring SupportsCatalogs.listCatalogs…
c5c9bef 
…() method to return String[] (apache#3741)

### What changes were proposed in this pull request?

Currently, the SupportsCatalogs.listCatalogs() method returns an array
of NameIdentifier to represents the catalogs. Actually a String[] will
be more clear and easier to use.

### Why are the changes needed?

To make the API more clear to use.

Fix: apache#3702

### Does this PR introduce _any_ user-facing change?

Almost not; Just return type changed, will be more simple.

### How was this patch tested?

Yes, many test cases cover this API.
@mchades @jerryshao
[apache#3589] improvement(relational catalog, core): add data type co…
42ba402 
…nverter api (apache#3590)

### What changes were proposed in this pull request?

 - Add `DataTypeConverter` interface for catalogs usage

### Why are the changes needed?

Fix: apache#3589 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

existing tests

Co-authored-by: Jerry Shao <[email protected]>
@mchades
split to catalog tests
a4a8100
mchades pushed a commit that referenced this pull request Jul 5, 2024
@danhuawang
[Minor] Frontend integration test failed in headless environment (apa…
445792f 
…che#4006)

### What changes were proposed in this pull request?

Frontend integration test failed in certain headless environment, like
the ec2 in aws.

### Why are the changes needed?

 Frontend integration test failed due to the following error:
```
 MetalakePageTest > initializationError FAILED
    org.openqa.selenium.WebDriverException: unknown error: Chrome failed to start: exited abnormally.
      (chrome not reachable)
      (The process started from chrome location /actions-runner/_work/gravitino-test/gravitino-test/gravitino/integration-test/build/chrome/chrome-linux/chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
    Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:17:03'
    System info: host: 'ip-172-31-5-251', ip: '172.31.5.251', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1020-aws', java.version: '1.8.0_412'
    Driver info: driver.version: ChromeDriver
    remote stacktrace: #0 0x561b8bc79869 <unknown>
    #1 0x561b8bc14383 <unknown>
    #2 0x561b8b9f6ca3 <unknown>
    #3 0x561b8ba1a286 <unknown>
    #4 0x561b8ba157cd <unknown>
    #5 0x561b8ba4f11d <unknown>
    #6 0x561b8ba49963 <unknown>
    #7 0x561b8ba1fe36 <unknown>
    #8 0x561b8ba20fd5 <unknown>
    #9 0x561b8bc41f90 <unknown>
    #10 0x561b8bc53d80 <unknown>
```

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

<img width="1492" alt="image"
src="https://github.com/datastrato/gravitino/assets/154112360/3e16870e-ad51-4677-aec5-8e8be0c68f9b">
@mchades mchades closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchades @mygrsun @shaofengshi