[#3702]refactor(API): Refactoring SupportsCatalogs.listCatalogs() method to return String[] #3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The document update will be raised soon in another PR: #3742 |
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…() method to return String[] (apache#3741) ### What changes were proposed in this pull request? Currently, the SupportsCatalogs.listCatalogs() method returns an array of NameIdentifier to represents the catalogs. Actually a String[] will be more clear and easier to use. ### Why are the changes needed? To make the API more clear to use. Fix: apache#3702 ### Does this PR introduce _any_ user-facing change? Almost not; Just return type changed, will be more simple. ### How was this patch tested? Yes, many test cases cover this API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the SupportsCatalogs.listCatalogs() method returns an array of NameIdentifier to represents the catalogs. Actually a String[] will be more clear and easier to use.
Why are the changes needed?
To make the API more clear to use.
Fix: #3702
Does this PR introduce any user-facing change?
Almost not; Just return type changed, will be more simple.
How was this patch tested?
Yes, many test cases cover this API.