-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3731] docs(API): Update the tutorial and document for the Java client API change #3742
Conversation
@shaofengshi /**
* Create a fileset metadata in the catalog.
*
* <p>If the type of the fileset object is "MANAGED", the underlying storageLocation can be null,
* and Gravitino will manage the storage location based on the location of the schema.
*
* <p>If the type of the fileset object is "EXTERNAL", the underlying storageLocation must be set.
*
* @param ident A fileset identifier.
* @param comment The comment of the fileset.
* @param type The type of the fileset.
* @param storageLocation The storage location of the fileset.
* @param properties The properties of the fileset.
* @return The created fileset metadata
* @throws NoSuchSchemaException If the schema does not exist.
* @throws FilesetAlreadyExistsException If the fileset already exists.
*/
Fileset createFileset(
NameIdentifier ident,
String comment,
Fileset.Type type,
String storageLocation,
Map<String, String> properties)
throws NoSuchSchemaException, FilesetAlreadyExistsException; The |
ok, I can update the java docs together in this PR |
8a366e0
to
a8347dd
Compare
a8347dd
to
3506e93
Compare
done, please review again, thanks! |
It's okay with me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes were proposed in this pull request?
Update the documentations for the latest Java API change
Why are the changes needed?
To make the document sync with API change.
Fix: #3731
Does this PR introduce any user-facing change?
No
How was this patch tested?
Document, local previewd.