Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename consensus tasks and split storage (BFT-476) #2366

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Jul 2, 2024

What ❔

This is a 2nd attempt at #2357 to redo it after #2364 has reverted it. The fix was cherry picked from #2365

Why ❔

The other PR accidentally changed the contracts submodule.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@aakoshh aakoshh force-pushed the bft-476-refactor branch from e69056c to bf2231f Compare July 2, 2024 08:18
@aakoshh aakoshh marked this pull request as ready for review July 2, 2024 08:28
@aakoshh aakoshh requested review from popzxc and brunoffranca July 2, 2024 09:43
@brunoffranca brunoffranca added this pull request to the merge queue Jul 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 2, 2024
@brunoffranca brunoffranca added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 81c8f53 Jul 2, 2024
46 checks passed
@brunoffranca brunoffranca deleted the bft-476-refactor branch July 2, 2024 14:01
irnb pushed a commit to vianetwork/via-server that referenced this pull request Jul 12, 2024
…labs#2366)

## What ❔

This is a 2nd attempt at
matter-labs#2357 to redo it after
matter-labs#2364 has reverted it. The
fix was cherry picked from
matter-labs#2365

## Why ❔

The other PR accidentally changed the contracts submodule.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.

---------

Co-authored-by: matias-gonz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants