Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update contracts submodule #2365

Closed
wants to merge 1 commit into from

Conversation

matias-gonz
Copy link
Collaborator

Update contracts submodule

@matias-gonz matias-gonz marked this pull request as ready for review July 2, 2024 07:57
@matias-gonz
Copy link
Collaborator Author

Close in favor of #2364

@matias-gonz matias-gonz closed this Jul 2, 2024
@aakoshh
Copy link
Contributor

aakoshh commented Jul 2, 2024

@matias-gonz what was the git command you had to do to change the submodule back?

@matias-gonz
Copy link
Collaborator Author

matias-gonz commented Jul 2, 2024

@aakoshh the submodule is a pointer to another repo and you can use git checkout to switch versions.
Example:

cd contracts
git checkout 8172969672cc6a38542cd8f5578c74b7e30cd3b4

github-merge-queue bot pushed a commit that referenced this pull request Jul 2, 2024
## What ❔

This is a 2nd attempt at
#2357 to redo it after
#2364 has reverted it. The
fix was cherry picked from
#2365

## Why ❔

The other PR accidentally changed the contracts submodule.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.

---------

Co-authored-by: matias-gonz <[email protected]>
irnb pushed a commit to vianetwork/via-server that referenced this pull request Jul 12, 2024
…labs#2366)

## What ❔

This is a 2nd attempt at
matter-labs#2357 to redo it after
matter-labs#2364 has reverted it. The
fix was cherry picked from
matter-labs#2365

## Why ❔

The other PR accidentally changed the contracts submodule.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.

---------

Co-authored-by: matias-gonz <[email protected]>
@matias-gonz matias-gonz deleted the matias-update-contracts-submodule branch July 30, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants