-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rename consensus tasks and split storage (BFT-476) #2357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@popzxc no, I don't know why it did that. Could it be a side effect of
|
@aakoshh I think it happened during the merge, e.g. you updated @brunoffranca please check the PR for suspicious things; if something doesn't seem to belong to the PR, it's generally better to ask about it. |
#2364) Reverts #2357 This PR changed the contracts submodule by mistake. cc @aakoshh @brunoffranca
## What ❔ This is a 2nd attempt at #2357 to redo it after #2364 has reverted it. The fix was cherry picked from #2365 ## Why ❔ The other PR accidentally changed the contracts submodule. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. --------- Co-authored-by: matias-gonz <[email protected]>
…labs#2357) ## What ❔ * Renames `FetcherTask` to `ExternalNodeTask` * Moves `run_main_node` to `mn::run_main_node` to match `en::run_external_node` * Splits `consensus::storage` into `consensus::storage::connection` and `consensus::storage::store` ## Why ❔ I'm working on matter-labs#2340 where I made these changes either because the naming was confusing or the module was getting very long and I thought it would make it easier to have it in two before adding more trait implementations to it. The PR was getting huge even before I did any actual work, so I decided to make a pure refactoring PR to make the other one easier to review later. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`.
matter-labs#2364) Reverts matter-labs#2357 This PR changed the contracts submodule by mistake. cc @aakoshh @brunoffranca
…labs#2366) ## What ❔ This is a 2nd attempt at matter-labs#2357 to redo it after matter-labs#2364 has reverted it. The fix was cherry picked from matter-labs#2365 ## Why ❔ The other PR accidentally changed the contracts submodule. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. --------- Co-authored-by: matias-gonz <[email protected]>
What ❔
FetcherTask
toExternalNodeTask
run_main_node
tomn::run_main_node
to matchen::run_external_node
consensus::storage
intoconsensus::storage::connection
andconsensus::storage::store
Why ❔
I'm working on #2340 where I made these changes either because the naming was confusing or the module was getting very long and I thought it would make it easier to have it in two before adding more trait implementations to it. The PR was getting huge even before I did any actual work, so I decided to make a pure refactoring PR to make the other one easier to review later.
Checklist
zk fmt
andzk lint
.