Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change chainId to u64 #167

Merged
merged 10 commits into from
Oct 6, 2023
Merged

feat: change chainId to u64 #167

merged 10 commits into from
Oct 6, 2023

Conversation

AnastasiiaVashchuk
Copy link
Contributor

No description provided.

@AnastasiiaVashchuk AnastasiiaVashchuk requested a review from a team as a code owner October 5, 2023 19:38
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (f98c4fa) 31.58% compared to head (11d1b88) 31.59%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   31.58%   31.59%           
=======================================
  Files         478      478           
  Lines       25463    25491   +28     
=======================================
+ Hits         8043     8053   +10     
- Misses      17420    17438   +18     
Files Coverage Δ
core/bin/external_node/src/config/mod.rs 18.18% <ø> (ø)
core/bin/system-constants-generator/src/utils.rs 0.00% <ø> (ø)
core/lib/config/src/configs/chain.rs 40.74% <ø> (ø)
core/lib/dal/src/blocks_web3_dal.rs 28.28% <ø> (ø)
core/lib/dal/src/transactions_web3_dal.rs 55.66% <ø> (ø)
core/lib/state/src/in_memory.rs 96.29% <100.00%> (+0.14%) ⬆️
core/lib/test_account/src/lib.rs 96.36% <100.00%> (+0.06%) ⬆️
core/lib/types/src/api/mod.rs 33.78% <ø> (ø)
core/lib/types/src/storage/mod.rs 88.57% <100.00%> (+0.33%) ⬆️
core/lib/types/src/transaction_request.rs 68.49% <100.00%> (-0.11%) ⬇️
... and 16 more

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/lib/basic_types/src/lib.rs Outdated Show resolved Hide resolved
core/lib/config/src/configs/chain.rs Outdated Show resolved Hide resolved
@AnastasiiaVashchuk AnastasiiaVashchuk added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit f14bf68 Oct 6, 2023
30 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[16.0.0](core-v15.1.1...core-v16.0.0)
(2023-10-11)


### ⚠ BREAKING CHANGES

* **vm:** Update Refund model
([#181](#181))

### Features

* change chainId to u64
([#167](#167))
([f14bf68](f14bf68))
* **merkle tree:** Provide Merkle proofs for tree entries and entry
ranges ([#119](#119))
([1e30d0b](1e30d0b))
* **storage:** save enum indices in RocksDB
([#162](#162))
([bab099d](bab099d))
* **vm:** Update Refund model
([#181](#181))
([92b6f59](92b6f59))


### Bug Fixes

* **db:** drop constraint prover_jobs_fri_l1_batch_number_fkey
([#173](#173))
([fa71650](fa71650))
* **vm:** Make execution status and stop reason public
([#169](#169))
([f98c4fa](f98c4fa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@hatemosphere hatemosphere deleted the anastasiia-pla-448 branch October 12, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants