feat(storage): save enum indices in RocksDB #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 31.77% 31.87% +0.10%
==========================================
Files 481 481
Lines 25593 25688 +95
==========================================
+ Hits 8132 8189 +57
- Misses 17461 17499 +38
☔ View full report in Codecov by Sentry. |
perekopskiy
commented
Oct 5, 2023
slowli
reviewed
Oct 5, 2023
Deniallugo
reviewed
Oct 5, 2023
slowli
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Ideally, this functionality should be tested. One approach that comes to mind is syncing RocksdbStorage from Postgres (you can test enum indices at this point) and then manually removing enum indices for all keys in the state CF (by directly using RocksDB operations), so that they can be synced again.
slowli
reviewed
Oct 6, 2023
slowli
previously approved these changes
Oct 9, 2023
…ocksdb-migration-for-enum-indices
slowli
approved these changes
Oct 9, 2023
perekopskiy
deleted the
perekopskiy-pla-563-implement-state-keeper-rocksdb-migration-for-enum-indices
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
🤖 I have created a release *beep* *boop* --- ## [16.0.0](core-v15.1.1...core-v16.0.0) (2023-10-11) ### ⚠ BREAKING CHANGES * **vm:** Update Refund model ([#181](#181)) ### Features * change chainId to u64 ([#167](#167)) ([f14bf68](f14bf68)) * **merkle tree:** Provide Merkle proofs for tree entries and entry ranges ([#119](#119)) ([1e30d0b](1e30d0b)) * **storage:** save enum indices in RocksDB ([#162](#162)) ([bab099d](bab099d)) * **vm:** Update Refund model ([#181](#181)) ([92b6f59](92b6f59)) ### Bug Fixes * **db:** drop constraint prover_jobs_fri_l1_batch_number_fkey ([#173](#173)) ([fa71650](fa71650)) * **vm:** Make execution status and stop reason public ([#169](#169)) ([f98c4fa](f98c4fa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Enumeration indices now are saved along with values in the same column family. Indices are added gradually for old DB entries. The number of keys processed each L1 batch is configurable.
Why ❔
Enumeration indices in storage are necessary for boojum upgrade.
Checklist
zk fmtandzk lint.