-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement dynamic L2-to-L1 log tree depth #126
Merged
slowli
merged 5 commits into
main
from
aov-pla-548-implement-dynamic-l2-l1-log-tree-depth
Oct 3, 2023
Merged
feat: Implement dynamic L2-to-L1 log tree depth #126
slowli
merged 5 commits into
main
from
aov-pla-548-implement-dynamic-l2-l1-log-tree-depth
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
+ Coverage 31.57% 31.58% +0.01%
==========================================
Files 477 477
Lines 25429 25432 +3
==========================================
+ Hits 8028 8032 +4
+ Misses 17401 17400 -1
☔ View full report in Codecov by Sentry. |
StanislavBreadless
approved these changes
Oct 3, 2023
ly0va
approved these changes
Oct 3, 2023
slowli
force-pushed
the
aov-pla-548-implement-dynamic-l2-l1-log-tree-depth
branch
from
October 3, 2023 12:26
41197ad
to
6291e07
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
🤖 I have created a release *beep* *boop* --- ## [15.1.0](core-v15.0.2...core-v15.1.0) (2023-10-03) ### Features * Implement dynamic L2-to-L1 log tree depth ([#126](#126)) ([7dfbc5e](7dfbc5e)) * **vm:** Introduce new way of returning from the tracer [#2569](#2569) ([#116](#116)) ([cf44a49](cf44a49)) * **vm:** Restore system-constants-generator ([#115](#115)) ([5e61bdc](5e61bdc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Danil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Implements dynamic depth of the in-memory L2-to-L1 log Merkle tree. Previously, this tree always had 512 items (if necessary, additional zero items were added at the end). With these changes, the tree has at least 512 items (with padding); the actual number of items is
max(512, items.len().next_power_of_two())
. This makes the change backward-compatible without needing any logic tied to L1 batch number etc.Why ❔
We want to allow larger Merkle tree depths than previously.
Checklist
zk fmt
andzk lint
.