-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vm): Introduce new way of returning from the tracer #2569 #116
Merged
Deniallugo
merged 2 commits into
main
from
mirror-deniallugo-pla-539-refactor-should_stop_execution-a4d5ca6625210471d9de66d61e7c9a41a336afb8
Oct 3, 2023
Merged
feat(vm): Introduce new way of returning from the tracer #2569 #116
Deniallugo
merged 2 commits into
main
from
mirror-deniallugo-pla-539-refactor-should_stop_execution-a4d5ca6625210471d9de66d61e7c9a41a336afb8
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… private at a4d5ca6625210471d9de66d61e7c9a41a336afb8
Deniallugo
requested review from
RomanBrodetski,
perekopskiy,
popzxc and
a team
as code owners
September 29, 2023 14:06
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 31.58% 31.60% +0.01%
==========================================
Files 477 477
Lines 25431 25457 +26
==========================================
+ Hits 8033 8045 +12
- Misses 17398 17412 +14
☔ View full report in Codecov by Sentry. |
Deniallugo
changed the title
Mirrors branch deniallugo-pla-539-refactor-should_stop_execution from…
feat(vm): Introduce new way of returning from the tracer #2569
Sep 29, 2023
Deniallugo
force-pushed
the
mirror-deniallugo-pla-539-refactor-should_stop_execution-a4d5ca6625210471d9de66d61e7c9a41a336afb8
branch
from
October 3, 2023 12:06
5b58643
to
9200898
Compare
StanislavBreadless
previously approved these changes
Oct 3, 2023
Signed-off-by: Danil <[email protected]>
Deniallugo
force-pushed
the
mirror-deniallugo-pla-539-refactor-should_stop_execution-a4d5ca6625210471d9de66d61e7c9a41a336afb8
branch
from
October 3, 2023 12:16
9200898
to
a1ad029
Compare
perekopskiy
approved these changes
Oct 3, 2023
StanislavBreadless
approved these changes
Oct 3, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
🤖 I have created a release *beep* *boop* --- ## [15.1.0](core-v15.0.2...core-v15.1.0) (2023-10-03) ### Features * Implement dynamic L2-to-L1 log tree depth ([#126](#126)) ([7dfbc5e](7dfbc5e)) * **vm:** Introduce new way of returning from the tracer [#2569](#2569) ([#116](#116)) ([cf44a49](cf44a49)) * **vm:** Restore system-constants-generator ([#115](#115)) ([5e61bdc](5e61bdc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Danil <[email protected]>
Deniallugo
deleted the
mirror-deniallugo-pla-539-refactor-should_stop_execution-a4d5ca6625210471d9de66d61e7c9a41a336afb8
branch
October 10, 2023 13:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… private at a4d5ca6625210471d9de66d61e7c9a41a336afb8
What ❔
Change the way we return stops from the tracers. Now it's possible to say that it's a specific problem during the execution.
Why ❔
It was hard to distinguish in Tracers, that was it a problem with tx execution, or tx successfully finished
Checklist
zk fmt
andzk lint
.