Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): Introduce new way of returning from the tracer #2569 #116

Conversation

Deniallugo
Copy link
Contributor

@Deniallugo Deniallugo commented Sep 29, 2023

… private at a4d5ca6625210471d9de66d61e7c9a41a336afb8

What ❔

Change the way we return stops from the tracers. Now it's possible to say that it's a specific problem during the execution.

Why ❔

It was hard to distinguish in Tracers, that was it a problem with tx execution, or tx successfully finished

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

… private at a4d5ca6625210471d9de66d61e7c9a41a336afb8
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (adfddfc) 31.58% compared to head (a1ad029) 31.60%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   31.58%   31.60%   +0.01%     
==========================================
  Files         477      477              
  Lines       25431    25457      +26     
==========================================
+ Hits         8033     8045      +12     
- Misses      17398    17412      +14     
Files Coverage Δ
core/lib/vm/src/tracers/traits.rs 81.81% <100.00%> (+9.09%) ⬆️
core/lib/vm/src/tracers/utils.rs 56.45% <ø> (ø)
...ync_core/src/api_server/execution_sandbox/error.rs 0.00% <ø> (ø)
..._core/src/api_server/execution_sandbox/validate.rs 0.00% <0.00%> (ø)
core/lib/vm/src/errors/halt.rs 17.39% <0.00%> (-1.66%) ⬇️
core/lib/vm/src/implementation/execution.rs 50.00% <33.33%> (+5.55%) ⬆️
core/lib/vm/src/tracers/result_tracer.rs 46.25% <50.00%> (+1.51%) ⬆️
core/lib/vm/src/tracers/storage_invocations.rs 0.00% <0.00%> (ø)
core/lib/vm/src/tracers/validation/mod.rs 0.00% <0.00%> (ø)
core/lib/vm/src/tracers/default_tracers.rs 45.54% <27.77%> (-0.70%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Deniallugo Deniallugo changed the title Mirrors branch deniallugo-pla-539-refactor-should_stop_execution from… feat(vm): Introduce new way of returning from the tracer #2569 Sep 29, 2023
@Deniallugo Deniallugo marked this pull request as draft September 29, 2023 16:00
CODEOWNERS Outdated Show resolved Hide resolved
@Deniallugo Deniallugo force-pushed the mirror-deniallugo-pla-539-refactor-should_stop_execution-a4d5ca6625210471d9de66d61e7c9a41a336afb8 branch from 5b58643 to 9200898 Compare October 3, 2023 12:06
@Deniallugo Deniallugo marked this pull request as ready for review October 3, 2023 12:07
Signed-off-by: Danil <[email protected]>
@Deniallugo Deniallugo force-pushed the mirror-deniallugo-pla-539-refactor-should_stop_execution-a4d5ca6625210471d9de66d61e7c9a41a336afb8 branch from 9200898 to a1ad029 Compare October 3, 2023 12:16
@Deniallugo Deniallugo enabled auto-merge October 3, 2023 12:20
@Deniallugo Deniallugo added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit cf44a49 Oct 3, 2023
23 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Oct 3, 2023
🤖 I have created a release *beep* *boop*
---


##
[15.1.0](core-v15.0.2...core-v15.1.0)
(2023-10-03)


### Features

* Implement dynamic L2-to-L1 log tree depth
([#126](#126))
([7dfbc5e](7dfbc5e))
* **vm:** Introduce new way of returning from the tracer
[#2569](#2569)
([#116](#116))
([cf44a49](cf44a49))
* **vm:** Restore system-constants-generator
([#115](#115))
([5e61bdc](5e61bdc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Danil <[email protected]>
@Deniallugo Deniallugo deleted the mirror-deniallugo-pla-539-refactor-should_stop_execution-a4d5ca6625210471d9de66d61e7c9a41a336afb8 branch October 10, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants