feat(vm): Restore system-constants-generator #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
requested review from
RomanBrodetski,
perekopskiy,
popzxc and
a team
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 31.57% 31.57%
=======================================
Files 477 478 +1
Lines 25429 25437 +8
=======================================
+ Hits 8028 8033 +5
- Misses 17401 17404 +3
☔ View full report in Codecov by Sentry. |
Deniallugo
changed the title
Deniallugo
force-pushed
the
mirror-deniallugo-pla-566-restore-system-constants-generator-4894f6cf6eab41a7a9825af52dc19a68f6666b29
branch
from
2700b8f to
bf41820
Compare
perekopskiy
reviewed
Oct 2, 2023
Deniallugo
force-pushed
the
mirror-deniallugo-pla-566-restore-system-constants-generator-4894f6cf6eab41a7a9825af52dc19a68f6666b29
branch
from
bf41820 to
0cc6b36
Compare
perekopskiy
previously approved these changes
Oct 2, 2023
StanislavBreadless
previously approved these changes
Oct 3, 2023
yarn.lock
Outdated
There was a problem hiding this comment.
Are you sure there should be changes to yarn.lock? Nothing has changed in terms of JS dependencies
…from private at 4894f6cf6eab41a7a9825af52dc19a68f6666b29
Deniallugo
dismissed stale reviews from StanislavBreadless and perekopskiy
via
bf9dba9
Deniallugo
force-pushed
the
mirror-deniallugo-pla-566-restore-system-constants-generator-4894f6cf6eab41a7a9825af52dc19a68f6666b29
branch
from
0cc6b36 to
bf9dba9
Compare
perekopskiy
approved these changes
Oct 3, 2023
…stants-generator-4894f6cf6eab41a7a9825af52dc19a68f6666b29
StanislavBreadless
approved these changes
Oct 3, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
🤖 I have created a release *beep* *boop* --- ## [15.1.0](core-v15.0.2...core-v15.1.0) (2023-10-03) ### Features * Implement dynamic L2-to-L1 log tree depth ([#126](#126)) ([7dfbc5e](7dfbc5e)) * **vm:** Introduce new way of returning from the tracer [#2569](#2569) ([#116](#116)) ([cf44a49](cf44a49)) * **vm:** Restore system-constants-generator ([#115](#115)) ([5e61bdc](5e61bdc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Danil <[email protected]>
Deniallugo
deleted the
mirror-deniallugo-pla-566-restore-system-constants-generator-4894f6cf6eab41a7a9825af52dc19a68f6666b29
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Restore system-constants-generator
Why ❔
This crate is rarely used, but it is important to keep it alive: it's used sometimes to tune our fee-related constants.
Making sure that the code at least compiles is the smallest yet essential part of maintenance.
Checklist
zk fmtandzk lint.