Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add Element Call room settings #9347

Merged
merged 28 commits into from
Oct 7, 2022
Merged

Add Element Call room settings #9347

merged 28 commits into from
Oct 7, 2022

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Oct 4, 2022 •
edited by github-actions bot
Loading

2022-10-04_13-58
2022-10-04_13-59

Here's what your changelog entry will look like:

✨ Features

  • Add Element Call room settings (#9347).

@SimonBrandner
Correctly setup EC perms on room creation
b421911 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Add VoipRoomSettingsTab
055faf6 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Show VoipRoomSettingsTab
0cdf7ca 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Show MSC3401 perms in room settings
ebcd2d5 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
i18n
88c3666 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Oct 4, 2022
@SimonBrandner SimonBrandner mentioned this pull request Oct 4, 2022
Closed
9 tasks
@SimonBrandner
Remove ScreenName
761e528 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Hide behind labs flag
adf9f19 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Add testid
b92a576 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Add tests
5491451 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
i18n
eb8b242 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner marked this pull request as ready for review October 4, 2022 14:21
@SimonBrandner SimonBrandner requested a review from a team as a code owner October 4, 2022 14:21
@SimonBrandner
Don't mix " and '
1b19491 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Fix indent
1e56fbc 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Fix test name
278f0fd 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Try to use existing power levels
9983434 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner requested review from turt2live and removed request for germain-gg and t3chguy October 5, 2022 15:56
@turt2live turt2live removed their request for review October 5, 2022 20:47
@SimonBrandner
Disable when insufficient perms
2a6bbda 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Fix tests
756bdaf 
Signed-off-by: Šimon Brandner <[email protected]>
turt2live
turt2live previously requested changes Oct 6, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking better, though the brand consideration and object type still need addressing.

@SimonBrandner SimonBrandner mentioned this pull request Oct 7, 2022
Closed
@SimonBrandner
Don't cast as any
14d9bab 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner mentioned this pull request Oct 7, 2022
Merged
@SimonBrandner SimonBrandner mentioned this pull request Oct 7, 2022
Merged
@SimonBrandner
Add EC brand
2bcdbf7 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
i18n
e7000b6 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Delint
d5ee3d6 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Fix tests
dfd4031 
Signed-off-by: Šimon Brandner <[email protected]>
robintown
robintown approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go

@robintown robintown dismissed turt2live’s stale review October 7, 2022 17:25

Resolved, and reviewer is away

@SimonBrandner SimonBrandner enabled auto-merge (squash) October 7, 2022 17:32
@SimonBrandner SimonBrandner merged commit 26a74a1 into develop Oct 7, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/feat/ec-perms branch October 7, 2022 18:10
turt2live
turt2live reviewed Oct 7, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it won't let me request changes now :(

src/components/views/rooms/RoomHeader.tsx
@@ -195,10 +195,11 @@ const VideoCallButton: FC<VideoCallButtonProps> = ({ room, busy, setBusy, behavi
let menu: JSX.Element | null = null;
if (menuOpen) {
const buttonRect = buttonRef.current!.getBoundingClientRect();
const brand = SdkConfig.get("element_call").brand;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an error waiting to happen: we should be using SdkConfig.get().element_call?.brand ?? DEFAULTS.element_call.brand instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed by #9376

@SimonBrandner SimonBrandner mentioned this pull request Oct 7, 2022
Merged
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this pull request Oct 29, 2022
@su-ex
Merge tag 'v3.59.0' into sc
4ebdd74 
* Include a file-safe room name and ISO date in chat exports ([\matrix-org#9440](matrix-org#9440)). Fixes element-hq/element-web#21812 and element-hq/element-web#19724.
* Room call banner ([\matrix-org#9378](matrix-org#9378)). Fixes element-hq/element-web#23453. Contributed by @toger5.
* Device manager - spinners while devices are signing out ([\matrix-org#9433](matrix-org#9433)). Fixes element-hq/element-web#15865.
* Device manager - silence call ringers when local notifications are silenced ([\matrix-org#9420](matrix-org#9420)).
* Pass the current language to Element Call ([\matrix-org#9427](matrix-org#9427)).
* Hide screen-sharing button in Element Call on desktop ([\matrix-org#9423](matrix-org#9423)).
* Add reply support to WysiwygComposer ([\matrix-org#9422](matrix-org#9422)). Contributed by @florianduros.
* Disconnect other connected devices (of the same user) when joining an Element call ([\matrix-org#9379](matrix-org#9379)).
* Device manager - device tile main click target ([\matrix-org#9409](matrix-org#9409)).
* Add formatting buttons to the rich text editor ([\matrix-org#9410](matrix-org#9410)). Contributed by @florianduros.
* Device manager - current session context menu ([\matrix-org#9386](matrix-org#9386)).
* Remove piwik config fallback for privacy policy URL ([\matrix-org#9390](matrix-org#9390)).
* Add the first step to integrate the matrix wysiwyg composer ([\matrix-org#9374](matrix-org#9374)). Contributed by @florianduros.
* Device manager - UA parsing tweaks ([\matrix-org#9382](matrix-org#9382)).
* Device manager - remove client information events when disabling setting ([\matrix-org#9384](matrix-org#9384)).
* Add Element Call participant limit ([\matrix-org#9358](matrix-org#9358)).
* Add Element Call room settings ([\matrix-org#9347](matrix-org#9347)).
* Device manager - render extended device information ([\matrix-org#9360](matrix-org#9360)).
* New group call experience: Room header and PiP designs ([\matrix-org#9351](matrix-org#9351)).
* Pass language to Jitsi Widget ([\matrix-org#9346](matrix-org#9346)). Contributed by @Fox32.
* Add notifications and toasts for Element Call calls ([\matrix-org#9337](matrix-org#9337)).
* Device manager - device type icon ([\matrix-org#9355](matrix-org#9355)).
* Delete the remainder of groups ([\matrix-org#9357](matrix-org#9357)). Fixes element-hq/element-web#22770.
* Device manager - display client information in device details ([\matrix-org#9315](matrix-org#9315)).
* Send Content-Type: application/json header for integration manager /register API ([\matrix-org#9490](matrix-org#9490)). Fixes element-hq/element-web#23580.
* Device manager - put client/browser device metadata in correct section ([\matrix-org#9447](matrix-org#9447)).
* update the room unread notification counter when the server changes the value without any related read receipt ([\matrix-org#9438](matrix-org#9438)).
* Don't show call banners in video rooms ([\matrix-org#9441](matrix-org#9441)).
* Prevent useContextMenu isOpen from being true if the button ref goes away ([\matrix-org#9418](matrix-org#9418)). Fixes matrix-org/element-web-rageshakes#15637.
* Automatically focus the WYSIWYG composer when you enter a room ([\matrix-org#9412](matrix-org#9412)).
* Improve the tooltips on the call lobby join button ([\matrix-org#9428](matrix-org#9428)).
* Pass the homeserver's base URL to Element Call ([\matrix-org#9429](matrix-org#9429)). Fixes element-hq/element-web#23301.
* Better accommodate long room names in call toasts ([\matrix-org#9426](matrix-org#9426)).
* Hide virtual widgets from the room info panel ([\matrix-org#9424](matrix-org#9424)). Fixes element-hq/element-web#23494.
* Inhibit clicking on sender avatar in threads list ([\matrix-org#9417](matrix-org#9417)). Fixes element-hq/element-web#23482.
* Correct the dir parameter of MSC3715 ([\matrix-org#9391](matrix-org#9391)). Contributed by @dhenneke.
* Use a more correct subset of users in `/remakeolm` developer command ([\matrix-org#9402](matrix-org#9402)).
* use correct default for notification silencing ([\matrix-org#9388](matrix-org#9388)). Fixes element-hq/element-web#23456.
* Device manager - eagerly create `m.local_notification_settings` events ([\matrix-org#9353](matrix-org#9353)).
* Close incoming Element call toast when viewing the call lobby ([\matrix-org#9375](matrix-org#9375)).
* Always allow enabling sending read receipts ([\matrix-org#9367](matrix-org#9367)). Fixes element-hq/element-web#23433.
* Fixes (element-hq/element-web/issues/22609) where the white theme is not applied when `white -> dark -> white` sequence is done. ([\matrix-org#9320](matrix-org#9320)). Contributed by @florianduros.
* Fix applying programmatically set height for "top" room layout ([\matrix-org#9339](matrix-org#9339)). Contributed by @Fox32.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@turt2live turt2live turt2live left review comments

@robintown robintown robintown approved these changes

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonBrandner @turt2live @robintown