Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not reverting back to light mode #22609

Closed
thanasistrisp opened this issue Jun 18, 2022 · 4 comments
Closed

Not reverting back to light mode #22609

thanasistrisp opened this issue Jun 18, 2022 · 4 comments
Assignees
@florianduros
Labels
A-Themes-Official Official themes (light, dark) O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@thanasistrisp
Copy link

thanasistrisp commented Jun 18, 2022 •
edited
Loading

Steps to reproduce

When windows go back from dark mode to light mode (either manually or with third party app, e.g. auto dark mode app) it remains in dark mode and I need to exit the app and reopen it manually, while all other apps are reverting correctly. The inverse procedure (from light mode to dark mode) works correctly.

Outcome

What did you expect?

To revert from dark mode to light mode correctly 

What happened instead?

It stays in dark mode

Operating system

Windows 11

Application version

Element Nightly: 0.0.1-nightly.2022061501

How did you install the app?

From https://element.io/get-started#nightly

Homeserver

matrix.org

Will you send logs?

No
@turt2live turt2live added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Themes-Official Official themes (light, dark) O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jun 26, 2022
@florianduros florianduros self-assigned this Sep 23, 2022
@florianduros
Copy link
Member

After investigation, I notice this behavior:

In case of light theme previously selected:

  • Element web is display => theme-light.css is loaded => light theme is applied
  • I switch to dark => theme-dark.css is loaded => dark theme is applied
  • I switch to light => theme-light.css is loaded => the dark theme is still effective and prevails on the light one
  • I switch to dark => no loading of theme-dark.css => dark theme is applied
  • I switch to light => theme-light.css is loaded => dark theme is still effective

In case of dark theme previously selected:

  • Element web is display => theme-dark.css is loaded => dark theme is applied
  • I switch to light => theme-light.css is loaded => light theme is applied
  • I switch to dark => theme-dark.css is loaded => dark theme is applied
  • I switch to light => no loading of theme-light.css => light theme is applied
  • I switch to dark => theme-dark.css is loaded => dark theme is applied

@florianduros florianduros mentioned this issue Sep 27, 2022
Merged
3 tasks
@florianduros
Copy link
Member

The fix just landed on the react-sdk develop branch.

@thanasistrisp
Copy link
Author

Will it also be available for desktop app? And if yes, when will it be available in nightly version?

@florianduros
Copy link
Member

Yes, the fix will be available for the desktop app and the next nightly version is tomorrow at 8am UK time.

@renovate renovate bot mentioned this issue Oct 25, 2022
Closed
1 task
@carpenike-bot carpenike-bot bot mentioned this issue Oct 25, 2022
Merged
1 task
@renovate renovate bot mentioned this issue Oct 28, 2022
Closed
1 task
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Oct 29, 2022
@su-ex
Merge tag 'v3.59.0' into sc
4ebdd74 
* Include a file-safe room name and ISO date in chat exports ([\matrix-org#9440](matrix-org#9440)). Fixes element-hq/element-web#21812 and element-hq/element-web#19724.
* Room call banner ([\matrix-org#9378](matrix-org#9378)). Fixes element-hq/element-web#23453. Contributed by @toger5.
* Device manager - spinners while devices are signing out ([\matrix-org#9433](matrix-org#9433)). Fixes element-hq/element-web#15865.
* Device manager - silence call ringers when local notifications are silenced ([\matrix-org#9420](matrix-org#9420)).
* Pass the current language to Element Call ([\matrix-org#9427](matrix-org#9427)).
* Hide screen-sharing button in Element Call on desktop ([\matrix-org#9423](matrix-org#9423)).
* Add reply support to WysiwygComposer ([\matrix-org#9422](matrix-org#9422)). Contributed by @florianduros.
* Disconnect other connected devices (of the same user) when joining an Element call ([\matrix-org#9379](matrix-org#9379)).
* Device manager - device tile main click target ([\matrix-org#9409](matrix-org#9409)).
* Add formatting buttons to the rich text editor ([\matrix-org#9410](matrix-org#9410)). Contributed by @florianduros.
* Device manager - current session context menu ([\matrix-org#9386](matrix-org#9386)).
* Remove piwik config fallback for privacy policy URL ([\matrix-org#9390](matrix-org#9390)).
* Add the first step to integrate the matrix wysiwyg composer ([\matrix-org#9374](matrix-org#9374)). Contributed by @florianduros.
* Device manager - UA parsing tweaks ([\matrix-org#9382](matrix-org#9382)).
* Device manager - remove client information events when disabling setting ([\matrix-org#9384](matrix-org#9384)).
* Add Element Call participant limit ([\matrix-org#9358](matrix-org#9358)).
* Add Element Call room settings ([\matrix-org#9347](matrix-org#9347)).
* Device manager - render extended device information ([\matrix-org#9360](matrix-org#9360)).
* New group call experience: Room header and PiP designs ([\matrix-org#9351](matrix-org#9351)).
* Pass language to Jitsi Widget ([\matrix-org#9346](matrix-org#9346)). Contributed by @Fox32.
* Add notifications and toasts for Element Call calls ([\matrix-org#9337](matrix-org#9337)).
* Device manager - device type icon ([\matrix-org#9355](matrix-org#9355)).
* Delete the remainder of groups ([\matrix-org#9357](matrix-org#9357)). Fixes element-hq/element-web#22770.
* Device manager - display client information in device details ([\matrix-org#9315](matrix-org#9315)).
* Send Content-Type: application/json header for integration manager /register API ([\matrix-org#9490](matrix-org#9490)). Fixes element-hq/element-web#23580.
* Device manager - put client/browser device metadata in correct section ([\matrix-org#9447](matrix-org#9447)).
* update the room unread notification counter when the server changes the value without any related read receipt ([\matrix-org#9438](matrix-org#9438)).
* Don't show call banners in video rooms ([\matrix-org#9441](matrix-org#9441)).
* Prevent useContextMenu isOpen from being true if the button ref goes away ([\matrix-org#9418](matrix-org#9418)). Fixes matrix-org/element-web-rageshakes#15637.
* Automatically focus the WYSIWYG composer when you enter a room ([\matrix-org#9412](matrix-org#9412)).
* Improve the tooltips on the call lobby join button ([\matrix-org#9428](matrix-org#9428)).
* Pass the homeserver's base URL to Element Call ([\matrix-org#9429](matrix-org#9429)). Fixes element-hq/element-web#23301.
* Better accommodate long room names in call toasts ([\matrix-org#9426](matrix-org#9426)).
* Hide virtual widgets from the room info panel ([\matrix-org#9424](matrix-org#9424)). Fixes element-hq/element-web#23494.
* Inhibit clicking on sender avatar in threads list ([\matrix-org#9417](matrix-org#9417)). Fixes element-hq/element-web#23482.
* Correct the dir parameter of MSC3715 ([\matrix-org#9391](matrix-org#9391)). Contributed by @dhenneke.
* Use a more correct subset of users in `/remakeolm` developer command ([\matrix-org#9402](matrix-org#9402)).
* use correct default for notification silencing ([\matrix-org#9388](matrix-org#9388)). Fixes element-hq/element-web#23456.
* Device manager - eagerly create `m.local_notification_settings` events ([\matrix-org#9353](matrix-org#9353)).
* Close incoming Element call toast when viewing the call lobby ([\matrix-org#9375](matrix-org#9375)).
* Always allow enabling sending read receipts ([\matrix-org#9367](matrix-org#9367)). Fixes element-hq/element-web#23433.
* Fixes (element-hq/element-web/issues/22609) where the white theme is not applied when `white -> dark -> white` sequence is done. ([\matrix-org#9320](matrix-org#9320)). Contributed by @florianduros.
* Fix applying programmatically set height for "top" room layout ([\matrix-org#9339](matrix-org#9339)). Contributed by @Fox32.
@renovate renovate bot mentioned this issue Nov 20, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florianduros florianduros

Labels
A-Themes-Official Official themes (light, dark) O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @florianduros @thanasistrisp